From owner-freebsd-stable@FreeBSD.ORG Wed Sep 13 20:26:31 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7269116A494 for ; Wed, 13 Sep 2006 20:26:31 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 807BA43D73 for ; Wed, 13 Sep 2006 20:26:23 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 802BD48A2B; Wed, 13 Sep 2006 22:26:22 +0200 (CEST) Received: from localhost (dlx163.neoplus.adsl.tpnet.pl [83.24.53.163]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id CB2CE48A26; Wed, 13 Sep 2006 22:26:16 +0200 (CEST) Date: Wed, 13 Sep 2006 22:26:03 +0200 From: Pawel Jakub Dawidek To: Gary Kline Message-ID: <20060913202603.GA72187@garage.freebsd.pl> References: <20060909173813.GA1388@FS.denninger.net> <20060913144605.GD70245@garage.freebsd.pl> <20060913181504.GB90378@thought.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: <20060913181504.GB90378@thought.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.2 required=3.0 tests=BAYES_00,MANY_EXCLAMATIONS, PLING_QUERY,RCVD_IN_NJABL_DUL,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: freebsd-stable@freebsd.org Subject: Re: ARRRRGH! Guys, who's breaking -STABLE's GMIRROR code?! X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2006 20:26:31 -0000 --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 13, 2006 at 11:15:04AM -0700, Gary Kline wrote: > On Wed, Sep 13, 2006 at 04:46:05PM +0200, Pawel Jakub Dawidek wrote: > > On Sat, Sep 09, 2006 at 12:38:13PM -0500, Karl Denninger wrote: > > > This is not cool folks. > >=20 > > I'm really sorry for the breakage. I'm trying to treat -STABLE very > > gently, unfortunately this time I made a mistake. > >=20 > > The change was committed to HEAD at 9 August. The change fixed one bug, > > but introduced another, which I didn't expected. The change seemed to be > > trivial and I only tested that it fixes the bug I was tracking down, I > > haven't looked for regressions. > >=20 > =09 > Well, after this lengthy discussion, I've switched to -RELEASE. > -STABLE just ain't... We all realize that none of us would=20 > put out a buggy release--not even -CURRENT. But let me ask > the next obvious question. How difficult would it be to > build a regression test, or suite of tests? Obviously, this > could be done over months -> years. (In my last lifetime > as a hacker I was in the kernel test group [a BSD-4.4 based=20 > release on new architecture]. ) It's a bit hard to believe=20 > that with all the genius in this effort, that no regression > testing is done. I'm trying to implement regression tests to the code I add. You can find them in /usr/src/tools/regression/: geom_concat 2 files, 2 tests geom_eli 15 files, 5818 tests geom_gate 3 files, 6 tests geom_mirror 7 files, 27 tests geom_nop 2 files, 2 tests geom_raid3 12 files, 13 tests geom_shsec 2 files, 6 tests geom_stripe 2 files, 2 tests ipsec 1 file, 306 tests redzone9 1 file, 6 tests usr.bin/pkill 27 files, 49 tests As I said already, I mistakenly thought the change was trivial and the only thing I tested was if it fixes a bug I was tracking down back then. We dicuss from time to time that we should have service simlar to tinderbox, which will run regression tests regularly and report regressions to the mailing lists - the more we automate the smaller chance for a human mistake like mine. Unfortunately this is not yet done. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFFCGlbForvXbEpPzQRAqh/AJ9Oa4wxGgrZArBYDFXKn9kYAlTX7ACgmF0j Vt7lhluRoNiwClItmRZhbEk= =8Tx0 -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62--