From owner-svn-src-head@freebsd.org  Tue Jul  3 14:57:03 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 678311027663;
 Tue,  3 Jul 2018 14:57:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D02958513C;
 Tue,  3 Jul 2018 14:57:02 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx
 [66.234.199.215])
 by mail.baldwin.cx (Postfix) with ESMTPSA id CCFD710AFD4;
 Tue,  3 Jul 2018 10:57:01 -0400 (EDT)
Subject: Re: svn commit: r335888 - in head: contrib/blacklist/bin
 lib/libpjdlog sbin/hastd
To: Ruslan Bukin <br@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201807031353.w63DrsAa079940@repo.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <980f862d-02d0-a1ce-cf4c-1d39021013fb@FreeBSD.org>
Date: Tue, 3 Jul 2018 07:57:00 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <201807031353.w63DrsAa079940@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Tue, 03 Jul 2018 10:57:02 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jul 2018 14:57:03 -0000

On 7/3/18 6:53 AM, Ruslan Bukin wrote:
> Author: br
> Date: Tue Jul  3 13:53:54 2018
> New Revision: 335888
> URL: https://svnweb.freebsd.org/changeset/base/335888
> 
> Log:
>   o Ensure va_list is declared by including stdarg.h.
>   o Also move printf.h to go after it since it does require declaration
>     of va_list.
>   
>   This fixes build with latest RISC-V GNU Toolchain with GCC 8.1

Normal style(9) is to sort headers.  Also, <printf.h> includes <stdio.h> already
so should already have va_list defined.  I think there is some other build problem
you are running into with GCC 8.1.  Did you ensure you stripped all of the
'include-fixed' headers when you updated riscv64-gcc?  This seems to be an issue
of busted headers in the compiler and these changes should probably be reverted.

-- 
John Baldwin