From owner-cvs-all  Mon Oct 14 12:23:15 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 78D9E37B401; Mon, 14 Oct 2002 12:23:14 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CBE2F43E9C; Mon, 14 Oct 2002 12:23:12 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id FAA12015;
	Tue, 15 Oct 2002 05:23:09 +1000
Date: Tue, 15 Oct 2002 05:33:33 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Mike Barcroft <mike@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/sys signal.h
In-Reply-To: <200210141412.g9EECHTp003405@repoman.freebsd.org>
Message-ID: <20021015052445.I2861-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 14 Oct 2002, Mike Barcroft wrote:

> mike        2002/10/14 07:12:17 PDT
>
>   Modified files:
>     sys/sys              signal.h
>   Log:
>   1) Although C99 allows implementations to define additional SIG*
>      constants in scope, C90 does not; so, add namespace visibility
>      conditionals to SIG*.

Er, C90 is the same as C99 here (both allow it).  I just prefer to keep
visibilility conditionals for the base standard(s).  They serve as
documentation if nothing else (signal.3 of course doesn't say which
signals are in which standards).  There are too many versions of standards
to ifdef for non-base standards, although we try to do this for functions
(standards mostly require this).  We actually only ifdef SIG* for POSIX.
The set of signals for C9[09] is small and uninteresting.  We do similar
things for E* in <errno.h>.

>   2) Define the extended __sighandler_t type only in BSD namespace.
>   3) Don't forward declare a struct for a prototype in <signal.h>.
>   4) Move location of SIG_* constants.
>   5) Move a forward declare into the correct namespace conditional.
>
>   Requested by:   bde (1)
>   Submitted by:   bde (2 thru 5)

Thanks.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message