Date: Wed, 20 Jun 2012 13:18:43 +0400 From: Gennady Proskurin <gprspb@mail.ru> To: Daniel O'Connor <doconnor@gsoft.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gennady Proskurin <gprspb@mail.ru>, src-committers@freebsd.org, Poul-Henning Kamp <phk@phk.freebsd.dk> Subject: Re: svn commit: r237223 - head/sys/dev/fb Message-ID: <20120620091843.GB832@gpr.nnz-home.ru> In-Reply-To: <A1A78677-4957-4690-A8F2-609F2207C92A@gsoft.com.au> References: <68FBE843-7337-4C90-B01F-E0CAABB62BCD@gsoft.com.au> <31750.1340083631@critter.freebsd.dk> <20120620074101.GA832@gpr.nnz-home.ru> <A1A78677-4957-4690-A8F2-609F2207C92A@gsoft.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 20, 2012 at 05:59:07PM +0930, Daniel O'Connor wrote:
>
> On 20/06/2012, at 17:11, Gennady Proskurin wrote:
> > On Tue, Jun 19, 2012 at 05:27:11AM +0000, Poul-Henning Kamp wrote:
> >> In message <68FBE843-7337-4C90-B01F-E0CAABB62BCD@gsoft.com.au>, "Daniel O'Conno
> >> r" writes:
> >>
> >>>> If size is odd, this does not copy the last byte. Not sure, whether =
> >>> this is intended.
> >>
> >> Feel free to improve...
> >
> > <fb.patch>
>
>
> Surely if you pass it an odd size you made a mistake - either the wrong function was used or you computed the size incorrectly.
Functions are called "bcopy_io" and so, such names tell nothing about data size
they work with ("copyw" tells something). If it is not supposed to work with
odd size, I agree, my patch is overkill, something like KASSERT (or just
one-line comment) is better.
I just wanted to be sure, that potential bug in this code is known to
developpers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120620091843.GB832>