From owner-svn-src-all@FreeBSD.ORG Mon Dec 1 16:09:00 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 08DDAE4F; Mon, 1 Dec 2014 16:09:00 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196]) by mx1.freebsd.org (Postfix) with ESMTP id DCC361C0; Mon, 1 Dec 2014 16:08:59 +0000 (UTC) Received: from [100.93.87.91] (184.sub-70-197-13.myvzw.com [70.197.13.184]) by elvis.mu.org (Postfix) with ESMTPSA id C2244341F84F; Mon, 1 Dec 2014 08:08:59 -0800 (PST) Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys From: Alfred Perlstein X-Mailer: iPhone Mail (12B436) In-Reply-To: Date: Mon, 1 Dec 2014 08:08:59 -0800 Message-Id: <92F537D5-E1C8-402E-9EDC-CB6270059BCA@mu.org> References: <201411262019.sAQKJaw4043557@svn.freebsd.org> <39377603.10OyiSzjWY@ralph.baldwin.cx> <872C180A-6ADD-469F-A801-3728DF134EEC@mu.org> <547C88A9.1070007@selasky.org> <5E1B6CD4-BBA7-4AD0-9982-E981015AF138@mu.org> <547C8A9C.4080603@selasky.org> <547C8CA2.8040305@selasky.org> <547C8DEF.5020809@selasky.org> To: Jack Vogel Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: Hans Petter Selasky , "src-committers@freebsd.org" , John Baldwin , "svn-src-all@freebsd.org" , Alfred Perlstein , "svn-src-head@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Dec 2014 16:09:00 -0000 Jack you were asked. Please see the review system.=20 Sent from my iPhone > On Dec 1, 2014, at 8:05 AM, Jack Vogel wrote: >=20 > There is no mystery about who's drivers these are, and its not like it wou= ld > take a lot of effort to figure out ownership and ask us for review.=20 >=20 > Remove this commit until I have had time to look it over! >=20 > Jack >=20 >=20 >> On Mon, Dec 1, 2014 at 7:56 AM, Alfred Perlstein wrote: >>=20 >>=20 >> > On Dec 1, 2014, at 7:49 AM, Hans Petter Selasky wrote= : >> > >> >> On 12/01/14 16:45, Alfred Perlstein wrote: >> >> >> >> > Hi, >> >>> >> >>> It is quite early, actually: >> >>> >> >>> SYSINIT(sysctl, SI_SUB_KMEM, SI_ORDER_FIRST, sysctl_register_all, 0);= >> >>> >> >>> In some parts of the machine independent, MI, code you neee to keep t= he TUNABLE_FETCH'es, because its run before SI_SUB_KMEM ! >> >> >> >> Then it will not work unless I move the global n_queues sysctl creatio= n into the driver's mod load function. >> >> >> >> Is that ok? >> > >> > Are you asking me? >>=20 >> In soviet russia no one is ever sure whom to ask for permission to procee= d. >>=20 >> (Also you have significant commits to the driver so it makes sense. ) >>=20 >>=20 >> > >> > --HPS >> > >> > >=20