From owner-svn-src-head@freebsd.org Sun Sep 13 00:56:33 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54978A0224B; Sun, 13 Sep 2015 00:56:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2333D198A; Sun, 13 Sep 2015 00:56:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacex6 with SMTP id ex6so108854169pac.0; Sat, 12 Sep 2015 17:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=JhSenBX5DLQq9MdlmStDitAuuo8M13SKXo057JR/M20=; b=mDtaSOHPD6mkBBfP0lbUXwCdtqP0ucSZR/clfrXSwnUumP4yYJONubnhGpbuKI+Ha0 aKYNu9gmcEwe2UURfwE82evN4YtBsVWKua9F8Gvv8DirkRu/0cUHpnRzmHSpwkVIFlrd po5uP0fxUh4apjHSEbjQibWVLyz4L58eXFhWXBGOlBBw9PcCyY10NScTbMgE6kEghDb3 Fo5nKGVU43VZFLTk3+6tgkNUQBqrAbsmzuwuAIkTp4Eek7AY/x1f1HBGBJ7mOmP2/PKC yQx8cGdd2aSt3AbzQm5jHn1kwugChcx5jFGE4SJhmOCqRIBtNo5ERHGZdjMsjMps9ldm 4iXA== X-Received: by 10.68.125.197 with SMTP id ms5mr16277491pbb.38.1442105792614; Sat, 12 Sep 2015 17:56:32 -0700 (PDT) Received: from [21.136.107.25] ([172.56.32.133]) by smtp.gmail.com with ESMTPSA id pi9sm7907906pbb.96.2015.09.12.17.56.31 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 12 Sep 2015 17:56:31 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r287465 - head/sys/dev/e1000 From: Garrett Cooper X-Mailer: iPhone Mail (12H321) In-Reply-To: <20150912224516.GU64965@strugglingcoder.info> Date: Sat, 12 Sep 2015 17:56:24 -0700 Cc: Eric Joyner , Sean Bruno , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <201509041607.t84G7S6f029313@repo.freebsd.org> <20150904161813.GX68814@strugglingcoder.info> <20150912224516.GU64965@strugglingcoder.info> To: hiren panchasara X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2015 00:56:33 -0000 > On Sep 12, 2015, at 15:45, hiren panchasara w= rote: >=20 >> On 09/12/15 at 07:23P, Eric Joyner wrote: >> For the errata, the (lack of) details are in the specification updates fo= r >> HW like I210, I211, 82575 etc. It would be in the ones updated in August >> 2015. >=20 > Yes, I (we) know erratas are there in the h/w specs. Point is, which > exact errata problem are you fixing here so I can go look up the spec > for more detail. Errata number/name and exact spec should also be quoted > for less ambiguity. (Think about someone having to debug this code 5 > years down the road.) As a general request, better commit notes would help a lot when dealing w= ith driver porting/upgrades. There are a few times in the past where I've tr= ied upgrading things or cherry picking commits and decided against it (or ra= n into other issues), so having more info to provide to management and test w= ould be extremely useful, especially when we need to qualify how much risk i= s associated with changes. Thanks!=