Date: Sat, 12 Sep 2015 17:56:24 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: hiren panchasara <hiren@strugglingcoder.info> Cc: Eric Joyner <erj@freebsd.org>, Sean Bruno <sbruno@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r287465 - head/sys/dev/e1000 Message-ID: <D62D2DE0-9510-4DD1-9D84-00163FD902E5@gmail.com> In-Reply-To: <20150912224516.GU64965@strugglingcoder.info> References: <201509041607.t84G7S6f029313@repo.freebsd.org> <20150904161813.GX68814@strugglingcoder.info> <CA%2Bb0zg84yTKgz_Nqv9FcrC2j38nLFrQn3X0GiwGKPnjcbPfOKw@mail.gmail.com> <20150912224516.GU64965@strugglingcoder.info>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 12, 2015, at 15:45, hiren panchasara <hiren@strugglingcoder.info> w=
rote:
>=20
>> On 09/12/15 at 07:23P, Eric Joyner wrote:
>> For the errata, the (lack of) details are in the specification updates fo=
r
>> HW like I210, I211, 82575 etc. It would be in the ones updated in August
>> 2015.
>=20
> Yes, I (we) know erratas are there in the h/w specs. Point is, which
> exact errata problem are you fixing here so I can go look up the spec
> for more detail. Errata number/name and exact spec should also be quoted
> for less ambiguity. (Think about someone having to debug this code 5
> years down the road.)
As a general request, better commit notes would help a lot when dealing w=
ith driver porting/upgrades. There are a few times in the past where I've tr=
ied upgrading things or cherry picking commits and decided against it (or ra=
n into other issues), so having more info to provide to management and test w=
ould be extremely useful, especially when we need to qualify how much risk i=
s associated with changes.
Thanks!=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D62D2DE0-9510-4DD1-9D84-00163FD902E5>