Date: Sun, 29 Jan 2017 12:55:46 -0600 From: John Marino <freebsd.contact@marino.st> To: Torsten Zuehlsdorff <freebsd@toco-domains.de>, John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: Mathieu Arnold <mat@FreeBSD.org> Subject: Re: svn commit: r432561 - head/lang/php71 Message-ID: <ce44c753-2d68-0899-b07c-cfaa92de1158@marino.st> In-Reply-To: <6aebcd6a-0439-f23a-be9d-e06f46d3511b@toco-domains.de> References: <201701271852.v0RIqOvW033749@repo.freebsd.org> <6aebcd6a-0439-f23a-be9d-e06f46d3511b@toco-domains.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/29/2017 12:50, Torsten Zuehlsdorff wrote: > > > On 27.01.2017 19:52, John Marino wrote: >> Author: marino >> Date: Fri Jan 27 18:52:24 2017 >> New Revision: 432561 >> URL: https://svnweb.freebsd.org/changeset/ports/432561 >> >> Log: >> lang/php71: Bring DTRACE exclude for DF from lang/php70 >> >> Maybe this would have been caught with SVN copy? Oh well. >> >> Approved by: just-fix-it > > Its funny how "just-fix-it" often translate in "just-broke-it" - see > r432567. > > But beside that back to being serious: why did nobody suggest a fix? If > repo-copy is this needed, we can do it right now? > svn rm lang/php71 && svn cp -r432321 lang/php70 lang/php71 && some files > copied would be all. > I took mat into CC because i want to know if something speaks against it > or if just nobody thought about it. > > Also fun note: with an svn copy the DTRACE option wouldn't be included > too. I finished the patch 2 month ago, long before DTRACE was > introduced. So it wouldn't be there. Which would be an error of process. - svn cp php70 - overwrite with your working copy - view with svn diff. The new additions in the last 2 months would be apparent. Thus the 3rd step wasn't done. You misunderstood r432567. That wasn't to correct my commit. That was to add the second missing item, DTRACE for aarch. > I just noted in this 2 month how hard it is to find somebody for review > and second how hard it is to get such a patch reviewed. First the > review.freebsd.org didn't work for me because it contains a bug with > umlaut for years. And second a repocopy could not be displayed. Yes, the diff would have been displayed. That's the benefit of repocopy. John --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ce44c753-2d68-0899-b07c-cfaa92de1158>