From owner-freebsd-current@FreeBSD.ORG Fri Aug 31 09:45:00 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFE0C106566C for ; Fri, 31 Aug 2012 09:45:00 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 9ABDC8FC0C for ; Fri, 31 Aug 2012 09:45:00 +0000 (UTC) Received: from [127.0.0.1] (Scott4long@pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.5/8.14.5) with ESMTP id q7V9iq9e073022; Fri, 31 Aug 2012 03:44:52 -0600 (MDT) (envelope-from scottl@samsco.org) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.0 \(1486\)) From: Scott Long In-Reply-To: <50407947.50907@andric.com> Date: Fri, 31 Aug 2012 03:44:52 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <414BFBFF-5F7C-45A5-8E0A-FC85FD39E29E@samsco.org> References: <504068F2.6010300@gmail.com> <50407947.50907@andric.com> To: Dimitry Andric X-Mailer: Apple Mail (2.1486) X-Spam-Status: No, score=-50.0 required=3.8 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on pooker.samsco.org Cc: deeptech71@gmail.com, freebsd-current@freebsd.org Subject: Re: sys/dev/amr build error with Clang X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2012 09:45:00 -0000 On Aug 31, 2012, at 2:43 AM, Dimitry Andric wrote: > On 2012-08-31 09:34, deeptech71@gmail.com wrote: >> /usr/src/sys/modules/amr/../../dev/amr/amr.c:970:1: error: function >> 'amr_periodic' is not needed and will not be emitted >> [-Werror,-Wunneeded-internal-declaration] >=20 > The one call to get the callout to amr_periodic() started seems to = have > been commented out in r239912: >=20 > = http://svnweb.freebsd.org/base/head/sys/dev/amr/amr.c?r1=3D239912&r2=3D239= 911&pathrev=3D239912 >=20 > If the function isn't necessary anymore, it could just be deleted, or > #ifdef'd out. Fixed in r239939. Thanks for the report. Scott