From nobody Tue Jul 14 01:20:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gzhLc1D1dz6ktWv for ; Tue, 14 Jul 2026 01:20:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gzhLc0gbQz4DMg for ; Tue, 14 Jul 2026 01:20:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783992008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ea0LifrLQ8ZnwQVTNVixThaZekCvPBLHUVvzbTkvE8A=; b=R7dJb9o+V0izo1SemuCMcN8TpWK7dZmTR3srbYNxjQtDowfQpIpGIaZb1YjV9jlG7WIRi2 olc9MQvbDUl6tqJSenDcXZXyjFOyEhMOey6TekrJhba7o9h9Dep7MU7yhS/vrfkS9ZNWa/ aFazUFlQm+kc/khKrYCqc2uJBS1DkO9I4IqRE6Qp2vE+YUCaT5c4GuLaOPPvEYUjRyXKZ/ NLzISvzFTxlD3WAuUMQubhiz0/GAYzP/O0dYw4d2exKwzMXzSneqXOvqYsjyCDZrCSgcbP g0KCgKiPmA8m4pc/UoFEQB4O2NwGkeFNi1wprO2vcgQ58NSB1JdJf5nHwyYwLQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783992008; a=rsa-sha256; cv=none; b=jZWURLOiIW9wHK+w+yKBX+Z1shVlZWFM1hGfdNOUh4dMdXIweBZxS6lY7ZZU1zPjONZqiW lFWhwaHJJo5Mdq7ZXRd/gUUHxX14ViVkc4a0go1HTjwm2/iM5s6L0uYjM/IlK0vuGZWv8u ULdbrBrwHF1wKNXsbg7HQAXoPD5hlm3muSYvswSnGAKc5MMQVvxdyx1xFn4ps7nQTTh4NJ Z4SyO3Hfax9TWsNhqKjyrdAvM/gbvsvrHQVHOFWNBLyjYfUOKV/dnFjl/aT6rCcJ/gOlnr WcQnByLUR+gIsfy4EbV1VNlHvBvxy7hOHTGXCLN1ENpR83LZ9LWwVpl74yfkEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783992008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ea0LifrLQ8ZnwQVTNVixThaZekCvPBLHUVvzbTkvE8A=; b=NMauJCeguz7YgGuSbkJIrBN3tVrg06Jr7+deIdgDPIdjwfsZckDdrgAOyu4ZUdNe4akHFh qrsEbBSh0nAKYQXGTuO4aiiyY0v29cGMxpRFS1yZQ4NN4TW47v1HXIv5IFBz0QE4aGak2S 8/ASM4vTgWrPhCfreLXXNpDPw6aCa6/zPUeZL7ORYpL0sQP8Jla/k4Y15ZATPSgghp+y8X tB1cnhvtEEfdgDIEC4vScnxoj7uY7zaqAuRNr80D+7EqXo31FJGyO+Wfc4T1YtWQKnBGxq aPbng0CkQ++tcM//9+6GuiIsjXg7S9CZtoDSq5FZcrZukw2D/5rDYYIg6pm1BQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gzhLb6KRTz6xb for ; Tue, 14 Jul 2026 01:20:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 264c5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 14 Jul 2026 01:20:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: 2e21f7e81404 - main - ena: Put taskqueues into correct domain if !RSS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2e21f7e8140447c2dcbc964ff3482f12f9bd6683 Auto-Submitted: auto-generated Date: Tue, 14 Jul 2026 01:20:02 +0000 Message-Id: <6a558ec2.264c5.37ae8091@gitrepo.freebsd.org> The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=2e21f7e8140447c2dcbc964ff3482f12f9bd6683 commit 2e21f7e8140447c2dcbc964ff3482f12f9bd6683 Author: Colin Percival AuthorDate: 2026-06-27 23:33:46 +0000 Commit: Colin Percival CommitDate: 2026-07-14 01:19:48 +0000 ena: Put taskqueues into correct domain if !RSS When compiled without 'options RSS', the ena driver created taskqueues using taskqueue_start_threads_cpuset passing a mask value of NULL, both in the ena_setup_tx_resources path (for enqueues) and in the ena_create_io_queues path (for the completion-processing). In the default configuration, on most EC2 instances, this results in taskqueues running in the right NUMA domain, but only by accident; in non-default configurations (e.g. with with multiple EBS volumes attached and associated NVMe taskqueues) the taskqueues may land in the wrong NUMA domain even on instance types where the one-EBS-one-ENA case produces the desired results. Set (struct ena_que)->domain and use that to inform the choice of CPU sets. On a c8gn.48xlarge EC2 instance this doubles throughput on a 32-TCP-stream benchmark. Reviewed by: akiyano MFC after: 7 days Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D57918 --- sys/dev/ena/ena.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 4f45d9103d76..79b9937991c1 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -726,6 +726,8 @@ ena_setup_tx_resources(struct ena_adapter *adapter, int qid) snprintf(thread_name, sizeof(thread_name), "%s txeq %d", device_get_nameunit(adapter->pdev), que->cpu); #else + if (que->domain >= 0) + cpu_mask = &cpuset_domain[que->domain]; snprintf(thread_name, sizeof(thread_name), "%s txeq %d", device_get_nameunit(adapter->pdev), que->id); #endif @@ -1671,6 +1673,9 @@ ena_create_io_queues(struct ena_adapter *adapter) #ifdef RSS cpu_mask = &queue->cpu_mask; +#else + if (queue->domain >= 0) + cpu_mask = &cpuset_domain[queue->domain]; #endif taskqueue_start_threads_cpuset(&queue->cleanup_tq, 1, PI_NET, cpu_mask, "%s queue %d cleanup", @@ -1815,6 +1820,8 @@ ena_setup_io_intr(struct ena_adapter *adapter) static int last_bind = 0; int cur_bind; int idx; +#else + int domain; #endif int irq_idx; @@ -1827,6 +1834,9 @@ ena_setup_io_intr(struct ena_adapter *adapter) last_bind = (last_bind + adapter->num_io_queues) % num_buckets; } cur_bind = adapter->first_bind; +#else + if (bus_get_domain(adapter->pdev, &domain)) + domain = -1; #endif for (int i = 0; i < adapter->num_io_queues; i++) { @@ -1860,7 +1870,7 @@ ena_setup_io_intr(struct ena_adapter *adapter) } adapter->que[i].domain = idx; #else - adapter->que[i].domain = -1; + adapter->que[i].domain = domain; #endif /* RSS */ }