From owner-freebsd-net@FreeBSD.ORG  Wed Feb 18 22:55:07 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1BBEA157
 for <freebsd-net@freebsd.org>; Wed, 18 Feb 2015 22:55:07 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E6A2FCD5
 for <freebsd-net@freebsd.org>; Wed, 18 Feb 2015 22:55:06 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1IMt6Sc024035
 for <freebsd-net@freebsd.org>; Wed, 18 Feb 2015 22:55:06 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMt6HT024034;
 Wed, 18 Feb 2015 22:55:06 GMT (envelope-from root)
Date: Wed, 18 Feb 2015 22:55:06 +0000
To: freebsd-net@freebsd.org
From: "ken (Ken Merry)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Updated] D1893: Fix special case in ip_fragment() to
 produce a more sensible chain of packets
Message-ID: <978ba84471490ba0672ab6a0c688d0b7@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1893: Fix special case in ip_fragment() to produce a more
 sensible chain of packets
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-mdwvnzzsrozqcmzhmbra>
X-Phabricator-To: <PHID-USER-v52xolcoqcueu4pembtt>
X-Phabricator-To: <PHID-USER-e73re76ob52gi4vjprnd>
X-Phabricator-To: <PHID-USER-mqlw6f5jjiqhbs4co7yd>
X-Phabricator-To: <PHID-USER-d7hlhjvonwbh6sezyfcn>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-jfdfp3ujmysz623mloir>
X-Phabricator-To: <PHID-USER-q3rwaaecfkbtb4lxr2gr>
X-Phabricator-To: <PHID-USER-gwqhkhyjx2ztt7b5iohf>
X-Phabricator-To: <PHID-USER-k5bbpaejfd56ik2tjj37>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-ug3kdqciycpghwfscl6v>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-To: <PHID-USER-hh4avozwa3ssphnwhjxx>
X-Phabricator-To: <PHID-USER-xs5piezwnsa6epounp3t>
X-Phabricator-To: <PHID-USER-ah3wymddbvtgvckylqmi>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-6lhetaumuav2dnivtfwe-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-6lhetaumuav2dnivtfwe-req@FreeBSD.org>
Thread-Index: NTM5NTRkZmFhY2M5ZGMyZjg3NmZhODJjMjFlIFTlGEo=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-reviewers>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Feb 2015 22:55:07 -0000

ken added a comment.

It looks okay to me.  The surrounding code has changed a good bit since that was committed in 2002.  By the way, I think Drew Gallatin originally wrote that chunk of code, but I can't remember for sure.

REVISION DETAIL
  https://reviews.freebsd.org/D1893

To: hselasky, pluknet, ae, np, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson, ken
Cc: freebsd-net