From owner-svn-src-projects@FreeBSD.ORG Wed Sep 19 19:42:56 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 31ED91065674; Wed, 19 Sep 2012 19:42:56 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104]) by mx1.freebsd.org (Postfix) with ESMTP id C16F08FC15; Wed, 19 Sep 2012 19:42:55 +0000 (UTC) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id BFFD23592DA; Wed, 19 Sep 2012 21:42:54 +0200 (CEST) Received: by snail.stack.nl (Postfix, from userid 1677) id 9F99F2847B; Wed, 19 Sep 2012 21:42:54 +0200 (CEST) Date: Wed, 19 Sep 2012 21:42:54 +0200 From: Jilles Tjoelker To: Brooks Davis Message-ID: <20120919194254.GA75105@stack.nl> References: <201209182028.q8IKS1lK056820@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201209182028.q8IKS1lK056820@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240675 - in projects/mtree: include lib/libc/gen X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2012 19:42:56 -0000 On Tue, Sep 18, 2012 at 08:28:01PM +0000, Brooks Davis wrote: > Author: brooks > Date: Tue Sep 18 20:28:01 2012 > New Revision: 240675 > URL: http://svn.freebsd.org/changeset/base/240675 > Log: > Implement VIS_GLOB support including compatibilty symbols required by > overlapping flags between FreeBSD and NetBSD. > Add a compatibility symbol for unvis() due to NetBSD's allocation of > a flag value for UNVIS_END rather than just using 1. > Add symbol version entries for new vis and unvis functions. > [snip] > Modified: projects/mtree/include/vis.h > ============================================================================== > --- projects/mtree/include/vis.h Tue Sep 18 20:20:29 2012 (r240674) > +++ projects/mtree/include/vis.h Tue Sep 18 20:28:01 2012 (r240675) > @@ -62,6 +62,7 @@ > #define VIS_HTTP1866 0x200 /* http-style &#num; or &string; */ > #define VIS_NOESCAPE 0x400 /* don't decode `\' */ > #define _VIS_END 0x800 /* for unvis */ > +#define VIS_GLOB 0x1000 /* encode glob(3) magics */ > > /* > * unvis return codes > > [snip] Is it really necessary to be binary compatible with NetBSD in the VIS_* constants or is it possible to keep our values for the VIS_* constants we already have? While symbol versioning works, it leaves additional code around forever, which would not be necessary if compatibility had been kept. -- Jilles Tjoelker