Date: Fri, 11 May 2012 00:31:40 +0400 From: Sergey Kandaurov <pluknet@freebsd.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: Peter Holm <pho@freebsd.org>, mckusick@freebsd.org, Doug Barton <dougb@freebsd.org>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: panic, seems related to r234386 Message-ID: <CAE-mSOJiVePP%2BrXPKWCFdzXwdxXNZWPX3uAYGPUo__b0sVPgWw@mail.gmail.com> In-Reply-To: <20120507201153.GA19942@dft-labs.eu> References: <4FA6F324.4080107@FreeBSD.org> <CAE-mSOJBHPP4E_2Hme5nwf0fGfckyRBWeAe9=kodHMmS6eQy%2Bg@mail.gmail.com> <4FA82269.6080406@FreeBSD.org> <20120507201153.GA19942@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8 May 2012 00:11, Mateusz Guzik <mjguzik@gmail.com> wrote: > On Mon, May 07, 2012 at 12:28:41PM -0700, Doug Barton wrote: >> On 05/06/2012 15:19, Sergey Kandaurov wrote: >> > On 7 May 2012 01:54, Doug Barton <dougb@freebsd.org> wrote: >> >> I got this with today's current, previous (working) kernel is r232719= . >> >> >> >> panic: _mtx_lock_sleep: recursed on non-recursive mutex struct mount = mtx >> >> @ /frontier/svn/head/sys/kern/vfs_subr.c:4595 >> >> ... >> >> > Please try this patch. >> > >> > Index: fs/ext2fs/ext2_vfsops.c >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > --- fs/ext2fs/ext2_vfsops.c =A0 =A0 (revision 235108) >> > +++ fs/ext2fs/ext2_vfsops.c =A0 =A0 (working copy) >> > @@ -830,7 +830,6 @@ >> > =A0 =A0 =A0 =A0 /* >> > =A0 =A0 =A0 =A0 =A0* Write back each (modified) inode. >> > =A0 =A0 =A0 =A0 =A0*/ >> > - =A0 =A0 =A0 MNT_ILOCK(mp); >> > =A0loop: >> > =A0 =A0 =A0 =A0 MNT_VNODE_FOREACH_ALL(vp, mp, mvp) { >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (vp->v_type =3D=3D VNON) { >> > >> >> Didn't help, sorry. I put 234385 through some pretty heavy load >> yesterday, and everything was fine. As soon as I move up to 234386, the >> panic triggered again. So I cleaned everything up, applied your patch, >> built a kernel from scratch, and rebooted. It was Ok for a few seconds >> after boot, then panic'ed again, I think in a different place, but I'm >> not sure because subsequent attempts to fsck the file systems caused new >> panics which overwrote the old ones before they could be saved. >> > > Another MNT_ILOCK was hiding few lines below, try this patch: > > http://student.agh.edu.pl/~mjguzik/patches/ext2fs-ilock.patch > > I've tested this a bit and I believe this fixes your problem. I just committed your fix in r235241 since it seems to have no relation to the problem reported by Peter Holm. --=20 wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSOJiVePP%2BrXPKWCFdzXwdxXNZWPX3uAYGPUo__b0sVPgWw>