From owner-svn-src-all@FreeBSD.ORG Wed Oct 22 08:23:42 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8681F106567D; Wed, 22 Oct 2008 08:23:42 +0000 (UTC) (envelope-from sos@freebsd.org) Received: from deepcore.dk (adsl.deepcore.dk [87.63.29.106]) by mx1.freebsd.org (Postfix) with ESMTP id 109308FC20; Wed, 22 Oct 2008 08:23:41 +0000 (UTC) (envelope-from sos@freebsd.org) Received: from [172.18.2.117] (axiell-gw1.novi.dk [77.243.61.137]) by deepcore.dk (8.14.3/8.14.2) with ESMTP id m9M7lMIx099226; Wed, 22 Oct 2008 09:48:09 +0200 (CEST) (envelope-from sos@freebsd.org) Message-Id: <38B9B4B2-0EC5-4399-B7C2-55C095D95EAE@freebsd.org> From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= To: John Baldwin In-Reply-To: <200810211851.m9LIptwg006141@svn.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Apple Message framework v929.2) Date: Wed, 22 Oct 2008 09:48:08 +0200 References: <200810211851.m9LIptwg006141@svn.freebsd.org> X-Mailer: Apple Mail (2.929.2) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (deepcore.dk [87.63.29.106]); Wed, 22 Oct 2008 09:48:09 +0200 (CEST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184135 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2008 08:23:42 -0000 Good catch!! thanks!! -S=F8ren On 21Oct, 2008, at 20:51 , John Baldwin wrote: > Author: jhb > Date: Tue Oct 21 18:51:55 2008 > New Revision: 184135 > URL: http://svn.freebsd.org/changeset/base/184135 > > Log: > Restore the default maximum segment size for the bus dma tag to 64k =20= > as it > is in 6.x and 7.x. The typo caused 64k transactions to be =20 > unnecessarily > split up into two PRD entries. > > Modified: > head/sys/dev/ata/ata-dma.c > > Modified: head/sys/dev/ata/ata-dma.c > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- head/sys/dev/ata/ata-dma.c Tue Oct 21 18:50:52 2008 = (r184134) > +++ head/sys/dev/ata/ata-dma.c Tue Oct 21 18:51:55 2008 = (r184135) > @@ -78,7 +78,7 @@ ata_dmainit(device_t dev) > ch->dma.unload =3D ata_dmaunload; > ch->dma.alignment =3D 2; > ch->dma.boundary =3D 65536; > - ch->dma.segsize =3D 63536; > + ch->dma.segsize =3D 65536; > ch->dma.max_iosize =3D 128 * DEV_BSIZE; > ch->dma.max_address =3D BUS_SPACE_MAXADDR_32BIT; > ch->dma.dma_slots =3D 6; > -S=F8ren