From owner-freebsd-bugs@freebsd.org  Mon May 30 02:59:11 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B36FB532A4
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Mon, 30 May 2016 02:59:11 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0B8B710BC
 for <freebsd-bugs@FreeBSD.org>; Mon, 30 May 2016 02:59:11 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u4U2xA9A032858
 for <freebsd-bugs@FreeBSD.org>; Mon, 30 May 2016 02:59:10 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 209850] [patch] units(1) has an incorrect getopt string,
 causing a segmentation fault when '-o' is used
Date: Mon, 30 May 2016 02:59:11 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: kdrakehp@zoho.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status keywords bug_severity priority component assigned_to
 reporter attachments.created
Message-ID: <bug-209850-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 May 2016 02:59:11 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209850

            Bug ID: 209850
           Summary: [patch] units(1) has an incorrect getopt string,
                    causing a segmentation fault when '-o' is used
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: kdrakehp@zoho.com
          Keywords: patch

Created attachment 170817
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D170817&action=
=3Dedit
Correct the getopt string in usr.bin/units/usits.c

The 'o' and 'H' options both use 'optarg' while the getopt string states th=
at
they do not take an option argument.  When the 'o' option is used the
'output_format' variable is set to the previous value of 'optarg'.  The
'output_format' is used as the format when using printf to output the resul=
t,
causing a segmentation fault when it is NULL.


How to reproduce:

printf '\n\n' | units -H m mm

Expected output:
        * 1
        / 1
Output:
        * 1000
        / 0.001


printf '\n\n' | units -o m mm

Expected output:
        * m
        / m
Output:
Segmentation fault

--=20
You are receiving this mail because:
You are the assignee for the bug.=