From owner-freebsd-stable Wed Mar 6 16: 5:31 2002 Delivered-To: freebsd-stable@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id E81F137B422 for ; Wed, 6 Mar 2002 16:05:16 -0800 (PST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id E2F837830D; Thu, 7 Mar 2002 10:35:13 +1030 (CST) Date: Thu, 7 Mar 2002 10:35:13 +1030 From: Greg Lehey To: Craig Boston Cc: sos@freebsd.dk, stable@freebsd.org Subject: Re: Request for testers of new ATA driver patches Message-ID: <20020307103513.C66287@wantadilla.lemis.com> References: <200203060821.g268LR045942@freebsd.dk> <3C864253.5000700@meoqu.gank.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3C864253.5000700@meoqu.gank.org> User-Agent: Mutt/1.3.23i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wednesday, 6 March 2002 at 10:22:43 -0600, Craig Boston wrote: > S?ren Schmidt wrote: > >> >> Hmm, the ATA driver doesn't allow access to the individual disks in >> a RAID for security reasons, but if you need it you just need to >> rip out the test for raid disk and return EBUSY in ata-disk.c:adopen(). >> Why binum wont play ball I have no idea, ask groggy... >> > I figued it was something like that. I really didn't like the idea of > accessing ad* directly on a RAID controller anyway, and was pretty > surprised that it actually worked. I just didn't want to take the time > to hack up vinum (since I would have to remember to reapply the patch > after every cvsup :) ). > > But if I'm going to be applying your ATA patch anyway... Hmm, it looks > to be a pretty simple fix. vinumio.c has a hardcoded list of devices and > their majors, apparently so vinum can be initialized before root is > mounted. Funny, I thought you couldn't have a vinum root partition... > WIP? Anyway, the following patch should do the trick. > > --- vinumio.c.orig Wed Mar 6 08:33:05 2002 > +++ vinumio.c Wed Mar 6 08:44:24 2002 > @@ -78,6 +78,8 @@ > devmajor = 116; > else if (bcmp(dname, "wd", 2) == 0) /* IDE disk */ > devmajor = 3; > + else if (bcmp(dname, "ar", 2) == 0) /* ATA RAID */ > + devmajor = 157; > else if (bcmp(dname, "da", 2) == 0) > devmajor = 13; > else if (bcmp(dname, "vn", 2) == 0) > > Rebuilt the world and kernel fine, and vinum seems to like ar0 as a disk > now, but if course the configuration is invalid since it's pointing at > ad4. I *THINK* I know how to safely migrate my volumes to the new device > names, but am doing a full backup right now just in case :) > > Greg: in case you don't read stable, to answer the question of why in > the world anyone would want to run vinum on an ATA RAID device, suffice > it to say it's a long story. But I'm copying you just in case anyone > else needs to do this as it's a very simple fix. Well, I do read -stable, and all messages with "Vinum" in the subject line get highlighted, but thanks for copying me. And yes, I find it a little strange that people would want to run Vinum on a RAID array, but hey, if that's what you want to do, I won't stop you. I'll commit the fix. Thanks. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message