From owner-cvs-src@FreeBSD.ORG  Wed Feb 28 10:31:35 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7B2CE16A401;
	Wed, 28 Feb 2007 10:31:35 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 3CE9113C481;
	Wed, 28 Feb 2007 10:31:35 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l1SAUp4c090425;
	Wed, 28 Feb 2007 03:30:53 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Wed, 28 Feb 2007 03:30:55 -0700 (MST)
Message-Id: <20070228.033055.-135505832.imp@bsdimp.com>
To: phk@phk.freebsd.dk
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <43468.1172657639@critter.freebsd.dk>
References: <20070228.031000.1649769988.imp@bsdimp.com>
	<43468.1172657639@critter.freebsd.dk>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Wed, 28 Feb 2007 03:30:53 -0700 (MST)
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/usb umass.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Feb 2007 10:31:35 -0000

In message: <43468.1172657639@critter.freebsd.dk>
            "Poul-Henning Kamp" <phk@phk.freebsd.dk> writes:
: In message <20070228.031000.1649769988.imp@bsdimp.com>, "M. Warner Losh" writes
: :
: 
: >: >  Create a new quirk READ_CAPACITY_OFFBY1 
: >: 
: >: A better idea would be to have scsi_da.c try to read the 
: >: last sector and chop it if it fails.
: >
: >Why is that a better idea?
: 
: Because it will work automatically and not rely on us preventively
: adding the bogus devices to the kernel.
: 
: Trivially testable quicks shouldn't have to be compiled into
: static lists.

Others have observed that the number of sectors on a disk should be
even.  Therefore if maxsectors returned is even, it implies an odd
number of sectors and should be adjusted.  That might be an even
easier path to follow...  I'm never sure when one can schedule
additional I/O inside of cam...

Warner