From owner-freebsd-fs@FreeBSD.ORG Sat Jun 12 19:40:27 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 42AE31065674 for ; Sat, 12 Jun 2010 19:40:27 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id B26C28FC17 for ; Sat, 12 Jun 2010 19:40:26 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o5CJeMpG049663 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 12 Jun 2010 22:40:22 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o5CJeMHA078076; Sat, 12 Jun 2010 22:40:22 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o5CJeMne078075; Sat, 12 Jun 2010 22:40:22 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 12 Jun 2010 22:40:22 +0300 From: Kostik Belousov To: Mikolaj Golub Message-ID: <20100612194022.GP13238@deviant.kiev.zoral.com.ua> References: <86mxv22ji7.fsf@zhuzha.ua1> <20100611191059.GF13238@deviant.kiev.zoral.com.ua> <86mxv0cb9z.fsf@kopusha.home.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hHiQ9nAwW5IGN2dL" Content-Disposition: inline In-Reply-To: <86mxv0cb9z.fsf@kopusha.home.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org Subject: Re: '#ifndef DIAGNOSTIC' in nfsclient code looks like a typo X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2010 19:40:27 -0000 --hHiQ9nAwW5IGN2dL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 12, 2010 at 10:15:52PM +0300, Mikolaj Golub wrote: >=20 > On Fri, 11 Jun 2010 22:10:59 +0300 Kostik Belousov wrote: >=20 > KB> All the changes should be converted to the KASSERTs. There is no poi= nt > KB> in doing > KB> if (something) > KB> panic(); > KB> for diagnostic; use > KB> KASSERT(something, (panic message)); >=20 > Please look at the attached patch. Almost there. According to style(9), the values should be explicitely compared with 0, unless the value is of the boolean type. I suggest you to change e.g. + KASSERT(uiop->uio_iovcnt =3D=3D 1 && + !(uio_uio_resid(uiop) & (DIRBLKSIZ - 1)), to + KASSERT(uiop->uio_iovcnt =3D=3D 1 && + (uio_uio_resid(uiop) & (DIRBLKSIZ - 1)) =3D=3D 0, and change + KASSERT((tcnp->cn_flags & HASBUF) && (fcnp->cn_flags & HASBUF), + ("nfs_rename: no name")); to + KASSERT((tcnp->cn_flags & HASBUF) !=3D 0 && (fcnp->cn_flags & HASBUF) != =3D 0, + ("nfs_rename: no name")); --hHiQ9nAwW5IGN2dL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkwT4qUACgkQC3+MBN1Mb4gAiwCfW3Cm3vzXSk2wnlnbg5pjlpv4 rNEAoIoNtjZAiTBUTch547aZn+DZruqP =EUq2 -----END PGP SIGNATURE----- --hHiQ9nAwW5IGN2dL--