From owner-cvs-src-old@FreeBSD.ORG Fri Mar 25 00:45:35 2011 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB6971065674 for ; Fri, 25 Mar 2011 00:45:35 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5461F8FC12 for ; Fri, 25 Mar 2011 00:45:35 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p2P0jZ9D081764 for ; Fri, 25 Mar 2011 00:45:35 GMT (envelope-from adrian@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p2P0jZlX081763 for cvs-src-old@freebsd.org; Fri, 25 Mar 2011 00:45:35 GMT (envelope-from adrian@repoman.freebsd.org) Message-Id: <201103250045.p2P0jZlX081763@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to adrian@repoman.freebsd.org using -f From: Adrian Chadd Date: Fri, 25 Mar 2011 00:45:24 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ath/ath_hal ah_eeprom_v14.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2011 00:45:35 -0000 adrian 2011-03-25 00:45:24 UTC FreeBSD src repository Modified files: sys/dev/ath/ath_hal ah_eeprom_v14.h Log: SVN rev 219980 on 2011-03-25 00:45:24Z by adrian After discussion with Felix Fietkau (nbd) about the ath9k Merlin LNA bit settings, it seems that our defines are backwards and don't match what is in the EEPROM documentation or internal driver. The ath9k code used to have a bitfield here, rather than a uint8_t, and there were #defines used to swap the order based on the endian of the platform - this wasn't because of nybble or bit ordering of the underlying host but because of what the compiler was doing. This may be the reason for the backwards field numbers, as ath9k had similar issues. Revision Changes Path 1.6 +8 -8 src/sys/dev/ath/ath_hal/ah_eeprom_v14.h