From owner-cvs-all Tue Mar 11 15:10:53 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8567637B401 for ; Tue, 11 Mar 2003 15:10:48 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id C97D243FE5 for ; Tue, 11 Mar 2003 15:10:43 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 96280 invoked by uid 1000); 11 Mar 2003 23:10:44 -0000 Date: Tue, 11 Mar 2003 15:10:44 -0800 (PST) From: Nate Lawson To: Alexander Kabaev Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vfsops.c src/sys/fs/fdescfs fdesc_vfsops.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/portalfs portal_vfsops.c src/sys/fs/pseudofs pseudofs.h src/sys/fs/smbfs ... In-Reply-To: <20030311221518.6B68437B401@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 11 Mar 2003, Alexander Kabaev wrote: > Modified files: > sys/fs/devfs devfs_vfsops.c > sys/fs/fdescfs fdesc_vfsops.c > sys/fs/hpfs hpfs_vfsops.c > sys/fs/ntfs ntfs_vfsops.c > sys/fs/nwfs nwfs_vfsops.c > sys/fs/portalfs portal_vfsops.c > sys/fs/pseudofs pseudofs.h > sys/fs/smbfs smbfs_vfsops.c > sys/fs/udf udf_vfsops.c > sys/fs/umapfs umap_vfsops.c > sys/fs/unionfs union_vfsops.c > sys/isofs/cd9660 cd9660_vfsops.c > sys/kern vfs_default.c > sys/sys mount.h > Log: > Rename vfs_stdsync function to vfs_stdnosync which matches more > closely what function is really doing. Update all existing consumers > to use the new name. > > Introduce a new vfs_stdsync function, which iterates over mount > point's vnodes and call FSYNC on each one of them in turn. > > Make nwfs and smbfs use this new function instead of rolling their > own identical sync implementations. > > Reviewed by: jeff Very nice! It's good to see the default ops doing more useful things although it is important to keep them from becoming complex in the future (i.e. if ops == UFS do one thing otherwise do something else). -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message