From nobody Mon Jul 6 15:49:14 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gv81D3Fqkz6kGGl for ; Mon, 06 Jul 2026 15:49:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gv81D1VXFz3Jm9 for ; Mon, 06 Jul 2026 15:49:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783352960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XsV557oWtWner70wosh1lacfptKqH6VuLVZrVPb3ZnI=; b=ISozf871xT7sujp5Qr2eL4YXoUwf0Lo63uEyd0Nvj+x1gabO79iWjF0IngdBqg+ccJ7web Aht8hktHpajE/LN7W3No38yEtW09PiSYVO9dqYnVopbN/sNrtgRmfxxKZBDNgpTv4NqFsu NQCsxeIwjlLTPgsNonr2UdGf90S7Sciv8SgYGx9wCKnwqAkffxvbs1ojnhGugKdJGVVdI2 fiKXZqmQYFLCfy9arEowAvWNeD0u79qQ3btoZWN9m5VegKJzq9ez8lGblu7UtwHcK3ebfm 0xb4NXz6hjrwXXwwKWpmouiLweFxYbWpreEjwKggOUzT4xDJ0zAu+E9OtSpr4g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783352960; a=rsa-sha256; cv=none; b=uMHcu0xvLNpjzKYWC803vSlLTzot1f63rYEq/lA1v/mpwfKvdK2Ghba7eN7Y0G/a1qYUqL GHF9DaEL9eYi6e8OuqsX7RKtQSr4J/DcAh6K7wQ8TF1fa4VI7e39bCk0T42Xc1QDrDuqlT CHFtcRa/ar+O4d4Pm6msjm3jQcy1JF6QFxt+J6Dw9l7akNC8Q6MIWHUm7NDTog6gr1A4CP 4xHfUMKqMV2MkEOW4+zycNing48q9WzAr6QlhvmQ2oFVAtv4LSFsXQqLajsQiEaLwo1M95 dTR16em1w1jqCMAZwrKjHF9M7AUUQPoyTqY70DdxzCKj1b70LHQ2n64g4Yri+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783352960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XsV557oWtWner70wosh1lacfptKqH6VuLVZrVPb3ZnI=; b=Jhom/vfqLjKFZ6roD82mGxcytMJMTE9VoGT4abevdBYsgF1PzkZqn1b0cgH84SYzn7hS8j 2mOBdaBuYPDrY0xyPEv1O/0OoFoal81u5segAP3f9HRnwbsdBNTXiWd1DZ5W98FTZmkPrW IexGFf+Jo0Hn4s3U4buQS91FYsxLxB6ViAjwdoxJXbKaM20tdZP8rT0JF1Z1z2ZjlyDVf6 W3/9UX4X2ws7+Ca39Cd4/lUVHmm//qc0owz010v/nUiEUKlweiB+RocbWn3w9IHBXrtN11 9tM2Uub5wJ7JdximMlmJ4AQ9uFkOpxUR/XoxBTxLvhXWGL+x4DIcBcqC7c3P/Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gv81C74LTz195y for ; Mon, 06 Jul 2026 15:49:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1eece by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 06 Jul 2026 15:49:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 58c73727d6e4 - main - vfs: Fix resource leaks in kern_symlinkat() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 58c73727d6e49de1fc4f4bc90621146cae8db2bc Auto-Submitted: auto-generated Date: Mon, 06 Jul 2026 15:49:14 +0000 Message-Id: <6a4bce7a.1eece.18e1b08e@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=58c73727d6e49de1fc4f4bc90621146cae8db2bc commit 58c73727d6e49de1fc4f4bc90621146cae8db2bc Author: Mark Johnston AuthorDate: 2026-07-06 15:42:52 +0000 Commit: Mark Johnston CommitDate: 2026-07-06 15:46:01 +0000 vfs: Fix resource leaks in kern_symlinkat() Fixes: 2ec2ba7e232d ("vfs: Add VFS/syscall support for Solaris style extended attributes") Reported by: Yuxiang Yang, Yizhou Zhao, Ao Wang, Xuewei Feng, Qi Li, and Ke Xu from Tsinghua University using GLM-5.2 from Z.ai Reviewed by: rmacklem, kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58053 --- sys/kern/vfs_syscalls.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index ec952cac1d2e..59d0c9c40927 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -1882,7 +1882,7 @@ restart: } if ((vn_irflag_read(nd.ni_dvp) & VIRF_NAMEDDIR) != 0) { error = EINVAL; - goto out; + goto out2; } VATTR_NULL(&vattr); vattr.va_mode = ACCESSPERMS &~ td->td_proc->p_pd->pd_cmask; @@ -1894,9 +1894,7 @@ restart: goto out2; #endif error = VOP_SYMLINK(nd.ni_dvp, &nd.ni_vp, &nd.ni_cnd, &vattr, syspath); -#ifdef MAC out2: -#endif VOP_VPUT_PAIR(nd.ni_dvp, error == 0 ? &nd.ni_vp : NULL, true); vn_finished_write(mp); NDFREE_PNBUF(&nd);