Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jun 2010 12:18:04 +0200 (CEST)
From:      Daniel Gerzo <danger@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/148206: [patch] databases/pecl-memcache - fix delete with recent version of memcached
Message-ID:  <201006281018.o5SAI4xl003977@alice.syscare.sk>
Resent-Message-ID: <201006281020.o5SAK1fN043707@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         148206
>Category:       ports
>Synopsis:       [patch] databases/pecl-memcache - fix delete with recent version of memcached
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 28 10:20:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Daniel Gerzo
>Release:        FreeBSD 8.0-STABLE amd64
>Organization:
SysCare s. r. o.
>Environment:
>Description:
There is a bug with pecl-memcache when used with recent versions of memcached (1.4.4).
The bug has been fixed upstream in the SVN, but they haven't cut the release yet and
it doesn't look like they will do so soon. Thus, we should include this patch ourselves.
>How-To-Repeat:
http://pecl.php.net/bugs/bug.php?id=16927
http://pecl.php.net/bugs/bug.php?id=17566
>Fix:
--- patch-memcache.c begins here ---
--- memcache.c.orig	2010-06-25 15:10:10.946196727 +0000
+++ memcache.c	2010-06-25 15:11:24.745661063 +0000
@@ -642,7 +642,7 @@
 			}
 
 			if (deleted) {
-				pool->protocol->delete(request, request->key, request->key_len, value);
+				pool->protocol->delete(request, request->key, request->key_len, exptime);
 			}
 			else {
 				pool->protocol->mutate(request, *key, request->key, request->key_len, invert ? -value : value, defval, defval_used, exptime);
@@ -676,7 +676,7 @@
 		}
 
 		if (deleted) {
-			pool->protocol->delete(request, request->key, request->key_len, value);
+			pool->protocol->delete(request, request->key, request->key_len, exptime);
 		}
 		else {
 			pool->protocol->mutate(request, keys, request->key, request->key_len, invert ? -value : value, defval, defval_used, exptime);
--- patch-memcache.c ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006281018.o5SAI4xl003977>