From owner-svn-src-all@freebsd.org Tue Dec 15 14:33:26 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB6AD4B7F09; Tue, 15 Dec 2020 14:33:26 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CwLN63y6hz3wMH; Tue, 15 Dec 2020 14:33:26 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 1E1D3260266; Tue, 15 Dec 2020 15:33:19 +0100 (CET) Subject: Re: svn commit: r368523 - head/sys/vm To: Mark Johnston Cc: Bryan Drewery , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202012102044.0BAKiTHh011767@repo.freebsd.org> From: Hans Petter Selasky Message-ID: Date: Tue, 15 Dec 2020 15:33:09 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4CwLN63y6hz3wMH X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 14:33:26 -0000 On 12/15/20 3:27 PM, Mark Johnston wrote: >> I'm seeing the following panic: >> >> panic("vm_wait in early boot") >> vm_wait_domain() >> kmem_alloc_contig_pages() >> kmem_alloc_contig_domainset() >> kmem_alloc_contig() >> contigmalloc() >> x86bios_alloc() >> vesa_configure() >> vesa_mod_event() >> vesa_module_register_init() >> mi_startup() > Is it on a NUMA system? I see that the new logic won't work properly if > there are empty domains, so this suggests that we really do need a > special contig iterator as discussed in the review. Yes, this is a numa system. I just noticed, that before r368523 "flags" was updated by _vm_domainset_iter_policy_init() to always contain M_NOWAIT and that avoids the wait logic, but I think x86bios_alloc() doesn't get its memory then. I'm not sure if x86bios_alloc() needs to be attached a bit later anyway? --HPS