From owner-cvs-src@FreeBSD.ORG  Tue Oct 12 22:17:08 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0C96516A4CE; Tue, 12 Oct 2004 22:17:08 +0000 (GMT)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 88D8F43D4C; Tue, 12 Oct 2004 22:17:07 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.1/8.13.1) with ESMTP id i9CMGuoY073261;
	Tue, 12 Oct 2004 15:17:00 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200410122217.i9CMGuoY073261@gw.catspoiler.org>
Date: Tue, 12 Oct 2004 15:16:56 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
To: alfred@FreeBSD.org
In-Reply-To: <20041012215157.GP38364@elvis.mu.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: jhb@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_subr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Oct 2004 22:17:08 -0000

On 12 Oct, Alfred Perlstein wrote:
> I like this, my only concern is that there may be places that
> call this with locks held but with the kernel/user buffer wired
> so that it can't fault.
> 
> Are you sure this isn't the case?  (specifically for some sysctls)

There are a number of sysctl handlers where I added code to wire the
buffer so that there was no danger of sleeping while a mutex is held.
Allocating a kernel buffer and doing an extra copy would be ugly.

> * John Baldwin <jhb@FreeBSD.org> [041012 11:27] wrote:
>> jhb         2004-10-12 18:27:14 UTC
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/kern             kern_subr.c 
>>   Log:
>>   Add a WITNESS_WARN() to uiomove() to whine if locks are held when this
>>   function is called.
>>   
>>   MFC after:      1 month
>>   
>>   Revision  Changes    Path
>>   1.89      +2 -0      src/sys/kern/kern_subr.c
>