From owner-svn-src-head@FreeBSD.ORG  Tue Apr 23 15:46:42 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 05164F60;
 Tue, 23 Apr 2013 15:46:42 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 by mx1.freebsd.org (Postfix) with ESMTP id D5C2A1C8C;
 Tue, 23 Apr 2013 15:46:41 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 30300B96B;
 Tue, 23 Apr 2013 11:46:41 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Eitan Adler <eadler@freebsd.org>
Subject: Re: svn commit: r249800 - head/sys/dev/bwn
Date: Tue, 23 Apr 2013 11:46:11 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; )
References: <201304231302.r3ND2w5V024981@svn.freebsd.org>
In-Reply-To: <201304231302.r3ND2w5V024981@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201304231146.11509.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Tue, 23 Apr 2013 11:46:41 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Apr 2013 15:46:42 -0000

On Tuesday, April 23, 2013 9:02:58 am Eitan Adler wrote:
> Author: eadler
> Date: Tue Apr 23 13:02:57 2013
> New Revision: 249800
> URL: http://svnweb.freebsd.org/changeset/base/249800
> 
> Log:
>   Avoid warning about uninitalized variable
>   
>   PR:		kern/176712
>   Submitted by:	Hiren Panchasara <hiren.panchasara@gmail.com> (earlier vesion)
>   Approved by:	cperciva (mentor)

I don't think this is correct.  In the 'back' case you want to reuse the previous
mbuf.  It doesn't have a physical address of 0.  Instead, the dr->setdesc() at the
bottom of this routine should use the previous physical address.  I think you can
fix this by reverting this and changing dr->setdesc() to use meta->mt_paddr instead
of paddr.

-- 
John Baldwin