Date: Tue, 23 Apr 2013 11:46:11 -0400 From: John Baldwin <jhb@freebsd.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r249800 - head/sys/dev/bwn Message-ID: <201304231146.11509.jhb@freebsd.org> In-Reply-To: <201304231302.r3ND2w5V024981@svn.freebsd.org> References: <201304231302.r3ND2w5V024981@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, April 23, 2013 9:02:58 am Eitan Adler wrote: > Author: eadler > Date: Tue Apr 23 13:02:57 2013 > New Revision: 249800 > URL: http://svnweb.freebsd.org/changeset/base/249800 > > Log: > Avoid warning about uninitalized variable > > PR: kern/176712 > Submitted by: Hiren Panchasara <hiren.panchasara@gmail.com> (earlier vesion) > Approved by: cperciva (mentor) I don't think this is correct. In the 'back' case you want to reuse the previous mbuf. It doesn't have a physical address of 0. Instead, the dr->setdesc() at the bottom of this routine should use the previous physical address. I think you can fix this by reverting this and changing dr->setdesc() to use meta->mt_paddr instead of paddr. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304231146.11509.jhb>