From owner-p4-projects@FreeBSD.ORG Tue Oct 16 17:23:37 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 4D50316A468; Tue, 16 Oct 2007 17:23:37 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E912416A417; Tue, 16 Oct 2007 17:23:36 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from swip.net (mailfe13.swip.net [212.247.155.129]) by mx1.freebsd.org (Postfix) with ESMTP id 5B5EC13C465; Tue, 16 Oct 2007 17:23:35 +0000 (UTC) (envelope-from hselasky@freebsd.org) X-Cloudmark-Score: 0.000000 [] Received: from [85.19.218.45] (account mc467741@c2i.net [85.19.218.45] verified) by mailfe13.swip.net (CommuniGate Pro SMTP 5.1.10) with ESMTPA id 260585671; Tue, 16 Oct 2007 18:23:33 +0200 From: Hans Petter Selasky To: Alfred Perlstein Date: Tue, 16 Oct 2007 18:23:59 +0200 User-Agent: KMail/1.9.7 References: <200709231625.l8NGPhaR097038@repoman.freebsd.org> <200709232113.34718.hselasky@freebsd.org> <20071016043133.GW31826@elvis.mu.org> In-Reply-To: <20071016043133.GW31826@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710161823.59940.hselasky@freebsd.org> Cc: Perforce Change Reviews , "Constantine A. Murenin" Subject: Re: PERFORCE change 126745 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 17:23:37 -0000 On Tuesday 16 October 2007, Alfred Perlstein wrote: > * Hans Petter Selasky [070923 13:13] wrote: > > Hi Constantine, > > > > Thanks for your input and I _know_ that my code is not 100% style > > compliant. Most of the style misbehaves are probably there due to the way > > my "xemacs" autoformatting behaves. And I love curly brackets and > > parenthesis, by the way :-) > > > > My plan is to clean up all the style stuff by a small C-program in the > > end, because doing it by hand is waste of my time. Probably it will take > > less time to write that program than the actual manual edit when we are > > talking about doing alot of edits. It wonders me if such a tool already > > exists, because the code is technically OK. > > > > Anyone that wants to be a little more constructive and point towards > > where the FreeBSD style transformer program is? I assume it would be > > extremely useful to everyone that is forced to use multiple different > > styles depending on what project they are contributing to, like me. Then > > before commit I will run that script and verify the differences. And > > that's it. > > > > --HPS > > Hans, one of the issues with doing such changes at the end is that it > effectively obliterates the ability to "cvs annotate" your code. I'm > sure perforce has an 'annotate' command as well. > > I would suggest that you find/fix the style now and apply it now rather > than later as the longer you wait, the more history you obliterate. Hi Alfred, I never heard about the annotate command. Can you explain a little bit how it works? I will do as you want and write that "style converter" first, before any other changes. I expect it might take a little bit time, something like a week. --HPS