From owner-cvs-all@FreeBSD.ORG Sun May 9 08:35:48 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0FED16A4CE; Sun, 9 May 2004 08:35:48 -0700 (PDT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 796A443D48; Sun, 9 May 2004 08:35:47 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.10/8.12.9) with ESMTP id i472nkOd015156; Thu, 6 May 2004 20:49:46 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 06 May 2004 20:50:28 -0600 (MDT) Message-Id: <20040506.205028.31252573.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <20040506193513.O44970@root.org> References: <20040506105124.O42462@root.org> <20040506.203312.01491062.imp@bsdimp.com> <20040506193513.O44970@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/i386 legacy.c src/sys/kern subr_smp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 May 2004 15:35:49 -0000 In message: <20040506193513.O44970@root.org> Nate Lawson writes: : On Thu, 6 May 2004, M. Warner Losh wrote: : > In message: <20040506105124.O42462@root.org> : > Nate Lawson writes: : > : On Thu, 6 May 2004, John Baldwin wrote: : > : > On Thursday 06 May 2004 11:54 am, Nate Lawson wrote: : > : > > njl 2004/05/06 08:54:03 PDT : > : > > : > : > > FreeBSD src repository : > : > > : > : > > Modified files: : > : > > sys/i386/i386 legacy.c : > : > > sys/kern subr_smp.c : > : > > Log: : > : > > Move the CPU newbus attachment to i386 legacy. The acpi_cpu device will : > : > > become just "cpu" and provide attachments in the !legacy case. : > : > > : > : > > Tested by: des : > : > : > : > By the way, it would be nice if the acpi_cpu(4) driver would still probe and : > : > attach to devices for non-existent CPUs but just device_disable() the : > : > associated device_t. This would keep the device from reprobing all the time. : > : : > : Good idea, I'll make that change tonight. The code I committed this : > : morning returns ENXIO for them so probe will get called multiple times. : > : Hmm, this may be more difficult than I first thought since some of the : > : internal routines walk all devices in the devclass, operating on their : > : resources. This change would require that code to have an extra case, : > : "device here but not active". Right now it assumes that if the device is : > : probed/attached, it is usable. : > : > The device is already there. All the device_disable() would do would : > keep it from being probed again. : : Yep, I realized that later. There's nothing requiring a driver to attach : a device to call device_disable() on it. I'm still not comfortable making : that change yet. It doesn't hurt anything to rescan the cpu probe : methods. And perhaps a change like enabling HTT will eventually trigger a : rescan and acpi_cpu can attach to the now available processor. I'm not sure what the right thing to do is, just pointing out a common misconception in how device_t nodes wind up in the tree and/or bound to a devclass. Warner