Date: Thu, 19 Aug 1999 21:57:07 -0400 (EDT) From: Kelly Yancey <kbyanc@posi.net> To: Christian Weisgerber <naddy@mips.rhein-neckar.de> Cc: freebsd-ports@freebsd.org Subject: Re: ports/13259: new port: editors/bvi Message-ID: <Pine.BSF.4.05.9908192151050.56675-100000@kronos.alcnet.com> In-Reply-To: <199908200010.CAA85994@bigeye.rhein-neckar.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 20 Aug 1999, Christian Weisgerber wrote: > In article <199908192141.RAA51208@kronos.alcnet.com> you write: > > > >Synopsis: new port: editors/bvi > > Objections: > - The port ignores CFLAGS. > - The dependency on ncurses is pointless; ncurses is part of the base > system. > > Those are trivial to fix, but there is a much more serious problem: > > - When I took a look at bvi 1.2.0beta some time ago, it blew up > into my face, because the code was written with the assumption > sizeof(off_t) == sizeof(long), which is wrong for all 32-bit BSD > machines (but not Linux). Getting rid of this will require some > work. > > The old version 1.1.1 this port uses doesn't know off_t at all. > The author simply uses long for file position/length throughout. Also, > he mostly uses K&R function definitions, i.e. no prototypes, which > means you're not going to get much in the way of automatic casts. This > doesn't bode well for the 32/64-bit conflicts. > > Kelly, how much testing have you given this port? > After about one minute, I can already tell you that saving a file > will append a garbage byte to it. > > I suggest that the port not be committed at this time. > Hrm. My testing consisted of opening a couple of files and seeing that I could do basic editting functions....however I didn not actually want to overwrite the files I was examining so I didn't save them. As for the 1.2 versus 1.1.1 issue, it was my understanding that 1.2 is beta so I chose to port the (supposedly) stable version. But in the light of the other problems which I admit that I did not know enough to look for (namely the 32-bit/64-bit conflicts) and the large amount of recoding necessary to fix bugs in code that is not my own, I would suggest that the PR be closed and the port scrapped. Sorry for wasting your time. I know what to watch out for next time... Thanks, Kelly ~kbyanc@posi.net~ FreeBSD - The Power To Serve - http://www.freebsd.org/ Join Team FreeBSD - http://www.posi.net/freebsd/Team-FreeBSD/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9908192151050.56675-100000>