From owner-freebsd-amd64@FreeBSD.ORG Thu Jun 13 21:07:57 2013 Return-Path: Delivered-To: freebsd-amd64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CDB4CA00; Thu, 13 Jun 2013 21:07:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 4228012F1; Thu, 13 Jun 2013 21:07:57 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r5DL7tOD013594; Fri, 14 Jun 2013 00:07:55 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r5DL7tOD013594 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r5DL7t5r013593; Fri, 14 Jun 2013 00:07:55 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 14 Jun 2013 00:07:55 +0300 From: Konstantin Belousov To: John Baldwin Subject: Re: amd64/179376: xhci ehci irq storm Message-ID: <20130613210755.GF91021@kib.kiev.ua> References: <201306110920.r5B9K1m4071258@freefall.freebsd.org> <51B7563D.20807@sviba.cz> <20130611174822.GR3047@kib.kiev.ua> <201306131018.30778.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Pgaa2uWPnPrfixyx" Content-Disposition: inline In-Reply-To: <201306131018.30778.jhb@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: dchagin@freebsd.org, Michal Sviba , freebsd-usb@freebsd.org, freebsd-amd64@freebsd.org X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jun 2013 21:07:57 -0000 --Pgaa2uWPnPrfixyx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 13, 2013 at 10:18:30AM -0400, John Baldwin wrote: > On Tuesday, June 11, 2013 1:48:22 pm Konstantin Belousov wrote: > > + count =3D pci_msi_count(self); > > + if (count >=3D 1) { > > + if (count > 1) > > + count =3D 1; >=20 > You can just drop the if and always do the assignment here, yes? > (Minor nit I know, and the original patch is fine for testing) The comparision is useless, I removed it in my repo, thank you. I remember somebody complained that xhci(4) cannot attach on the Macs with the diagnostic about missing PRT entry for routing the legacy interrupt. As if Apple does not care about proper legacy routing. Hopefully, use of MSI-X would help there too. Here is it: http://lists.freebsd.org/pipermail/freebsd-current/2013-February/039595.html http://people.freebsd.org/~dchagin/macbookpro/dmesg.generic.HEAD.txt --Pgaa2uWPnPrfixyx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJRujSqAAoJEJDCuSvBvK1BUfQQAI8RZZXjoz13fQ7axTYKP8/s 2ZyqgxTveAhvaKJi5JxF4YdA8wx0KmVK4hzqUS9EZuHyLr/xUtf5tHMEme6ZTE13 6inB6Etftw7Znf4vt/hvgoIs53V76nVxp3vLYvPPm7MwHogjkZdziJFRs8NLgmV8 2mwOXyJmcbvOvF9KtO0zUMXcPgttb/417vPM5KZQ302XRpuwz840/4M8CMFP9B1Y LFucIVwsNiMG7B2GfMvqfJs9+gJsY9x/0iTNgFCw6YgoOWYv3xO8oueFgZM2KIwk T52/zaJw7BeLt406ZEj6zjGGISYx6lgKOO/IYdN+VQhez2pXkwtk8nZzfKtt+Erc UjM68iIimPAXJ2Wk1bpa2a4IZR30w65ri858XtRNFCUpc8CqMzPu7KefLpOpClF4 pI8SBayiUPBcu9YQ2RUjyBCTKBYE9LsxDFHXZ1zrtDr+uQhEgfhaq7eVv6WWC/nU lwHZQGVCO9bLJqLxvWzzg/wM8/R0OySERr9I7n3LGOyg7S4vm4CcBii4K/1G0N8b wK/aUug9x4M5j4deFAi++4otf3e2vWDCxqiBKO74tOPb/EFS6h71aTgkSxL7glhy xueFpe9Ax1Rv3Hpp8TZDYfquzgWuWPEOxcXpWpWDbrPC9DLrPrlJQBp6Ag8I4lwe NbGTiZ/cvwYpZE3jz2D5 =NE9R -----END PGP SIGNATURE----- --Pgaa2uWPnPrfixyx--