Date: Mon, 13 Apr 2009 04:18:53 GMT From: Scot Hetzel <swhetzel@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/133688: [patch] x11-toolkits/termit: WITHOUT_NLS fails to disable NLS support Message-ID: <200904130418.n3D4IrSS055769@www.freebsd.org> Resent-Message-ID: <200904130420.n3D4K1UC085217@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 133688
>Category: ports
>Synopsis: [patch] x11-toolkits/termit: WITHOUT_NLS fails to disable NLS support
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Apr 13 04:20:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Scot Hetzel
>Release: 8.0-CURRENT
>Organization:
>Environment:
>Description:
When the port is build with WITHOUT_NLS, it fails to dissable NLS support since the port uses cmake instead of a configure script.
>How-To-Repeat:
cd /usr/ports/x11-toolkits/termit
make configure -DWITHOUT_NLS
cd work/termit*/
ccmake .
ENABLE_NLS will still be set to ON.
>Fix:
The attached patch replaces 'CONFIGURE_ARGS+= --disable-nls' with 'CMAKE_ARGS+= -DENABLE_NLS:BOOL=false'
Patch attached with submission follows:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/x11-toolkits/termit/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile 8 Apr 2009 09:22:14 -0000 1.4
+++ Makefile 13 Apr 2009 03:08:50 -0000
@@ -29,7 +29,7 @@
LDFLAGS+= -L${LOCALBASE}/lib
CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
.else
-CONFIGURE_ARGS+=--disable-nls
+CMAKE_ARGS+= -DENABLE_NLS:BOOL=false
PLIST_SUB+= NLS="@comment "
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904130418.n3D4IrSS055769>