From owner-freebsd-virtualization@freebsd.org Thu Jun 13 18:36:20 2019 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F0FA15B9A66 for ; Thu, 13 Jun 2019 18:36:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 256C369CBD for ; Thu, 13 Jun 2019 18:36:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D9D4715B9A64; Thu, 13 Jun 2019 18:36:19 +0000 (UTC) Delivered-To: virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B538015B9A63 for ; Thu, 13 Jun 2019 18:36:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F74E69CB8 for ; Thu, 13 Jun 2019 18:36:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 73B3414E5C for ; Thu, 13 Jun 2019 18:36:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5DIaIK6053130 for ; Thu, 13 Jun 2019 18:36:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5DIaItw053129 for virtualization@FreeBSD.org; Thu, 13 Jun 2019 18:36:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 205549] bhyve pci passthru stops working after guest is restarted Date: Thu, 13 Jun 2019 18:36:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ark@dudevich.dn.ua X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jun 2019 18:36:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205549 --- Comment #6 from arkadyi --- Hmm....I don't see in the file usr.sbin/bhyve/pci_passthru.c (origin) bellow strings 642 pci_set_cfgdata16(pi, PCIR_COMMAND, read_config(&sc->psc_sel, 643 PCIR_COMMAND, 2)); # patch < D20623.diff=20 Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: usr.sbin/bhyve/pci_passthru.c |=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D |--- usr.sbin/bhyve/pci_passthru.c |+++ usr.sbin/bhyve/pci_passthru.c -------------------------- Patching file pci_passthru.c using Plan A... Hunk #1 succeeded at 615 (offset -3 lines). Hunk #2 succeeded at 625 (offset -3 lines). Hunk #3 failed at 648. 1 out of 3 hunks failed--saving rejects to pci_passthru.c.rej done cat /usr/src/usr.sbin/bhyve/pci_passthru.c.rej @@ -636,8 +648,13 @@ goto done; } - pci_set_cfgdata16(pi, PCIR_COMMAND, read_config(&sc->psc_sel, - PCIR_COMMAND, 2)); + /* + * Fetch the updated virtual command register and write it to + * the device if needed. + */ + cmd =3D pci_get_cfgdata16(pi, PCIR_COMMAND); + if (cmd !=3D orig_cmd) + write_config(&sc->psc_sel, PCIR_COMMAND, 2, cmd); error =3D 0; /* success */ done: uname -srv FreeBSD 12.0-RELEASE-p5 FreeBSD 12.0-RELEASE-p5 r349013 --=20 You are receiving this mail because: You are the assignee for the bug.=