From owner-freebsd-current@FreeBSD.ORG Sat Jan 19 08:27:54 2013 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B5A24605; Sat, 19 Jan 2013 08:27:54 +0000 (UTC) (envelope-from jh@FreeBSD.org) Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi [195.197.172.115]) by mx1.freebsd.org (Postfix) with ESMTP id 5839AEC; Sat, 19 Jan 2013 08:27:53 +0000 (UTC) Received: from a91-153-116-96.elisa-laajakaista.fi (a91-153-116-96.elisa-laajakaista.fi [91.153.116.96]) by gw01.mail.saunalahti.fi (Postfix) with SMTP id B02981514AB; Sat, 19 Jan 2013 10:27:41 +0200 (EET) Date: Sat, 19 Jan 2013 10:27:40 +0200 From: Jaakko Heinonen To: Alexander Motin Subject: Re: panic after r244584 Message-ID: <20130119082739.GA1956@a91-153-116-96.elisa-laajakaista.fi> References: <20130118073600.GA70874@hell.ukr.net> <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> <50F94D80.7000809@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50F94D80.7000809@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "Justin T. Gibbs" , satan@ukr.net, Gleb Smirnoff , freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jan 2013 08:27:54 -0000 On 2013-01-18, Alexander Motin wrote: > At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are > impossible there, as previous name components are unique. Special > characters haven't yet seen, but I think theoretically possible. I see two possible solutions for the problem. 1) Replace non-printable, space and '/' characters for example with '_'. '/' should be replaced anyway. 2) Apply the patches in http://lists.freebsd.org/pipermail/svn-src-all/2013-January/063661.html to allow spaces again. I haven't committed the patches because I think that there isn't full consensus that it's right thing to do and also I personally prefer not to have spaces in device names. -- Jaakko