From owner-freebsd-current@freebsd.org Mon Dec 16 23:15:41 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A0151D138C for ; Mon, 16 Dec 2019 23:15:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47cHF81PJwz4RvM for ; Mon, 16 Dec 2019 23:15:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf44.google.com with SMTP id p2so3442685qvo.10 for ; Mon, 16 Dec 2019 15:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WkfP1fZmQ0GI+zRutWwCeYC9NJZvC9JGndSWYWzCkr8=; b=lOe9SpygS1ucCQLKJJRBjGv9K8Hx9NPOTBjx07DgPiafkyoJMp+d5A9ZMuuZODTJhr rqxyFm20iKOYy3ujSIfuG7Mfj95e4fyNhA0dUbSa6mLo4YLt8cXrsf5KZNsVRY7W3ew/ n2UtDKFy4/UR2ybVE6KK554cBjLo5ap2tIOgyyNmevERmTkROT2L/48YG3tjaT34ApUO Xn/qJ8iBQYMScHHigFS3G64WTvUMkMJpIcxcs+xFgoEHUxpuiU8jYsY+1bAy7YxDfvhM 3SsSa2eIRZL+EVaA3Jan75ts2VA0w4pJGZOgslUO+GeNiaDn2YKF19tRvD62pKC1gTof 8PgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WkfP1fZmQ0GI+zRutWwCeYC9NJZvC9JGndSWYWzCkr8=; b=KDGL66XAvbC8gI/ffgsIUSZRnzQxkrci5pUATN9+xlR8nZ3uMa6uI/X6wk/F4DP2bV 56peEYOqToOFtid4aU+IawlLFzWkMbxUJTyaZjiOSOb5ykokIR6psjJGc/sjkMZNRnIt fEPKvQXqhvDOKB3YkOVGO4eCYq/INioFy8NgN+6IdYsfEJ7fRQYzhPjtrhLml1s5Ma5d tWe0rDOFv5+ILeMQwq/QHAsgubjCHzvD2N3xTer6UMA1/SLGoNO4ousYzW7Kwy7boGpR Ozswn6LQDrJ6clCiSkvMvhXujgOQ2dGPVkrim3wx2C0qQQIfDQJ5ttQOpJbAgD5Q5nE9 5SHg== X-Gm-Message-State: APjAAAVUTkuFq+8i9DOWLpdcu90YM3GNIoT3TwF++Wds/fBhX8tAerv7 ObHzpAVXhZA+I4L+motDyG09eJOgUf05e3Qoric+wA== X-Google-Smtp-Source: APXvYqyvyNipQDY6woXkIIo9N9v8LBhRPd9UQGeTTvL5YeQmTM7tNQcwWCMBGjzSxZiwjPuSmPozuzXchldSdyWiH2A= X-Received: by 2002:a0c:91b4:: with SMTP id n49mr1958312qvn.202.1576538138926; Mon, 16 Dec 2019 15:15:38 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Mon, 16 Dec 2019 16:15:27 -0700 Message-ID: Subject: Re: error building scsi_da.c with recent current To: pete wright Cc: FreeBSD Current X-Rspamd-Queue-Id: 47cHF81PJwz4RvM X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=lOe9Spyg; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f44) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.77 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.997,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[9]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-0.78)[ip: (0.26), ipnet: 2607:f8b0::/32(-2.19), asn: 15169(-1.90), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 23:15:41 -0000 The prior version (r355814) works just fine, if you wanted to get going... Sorry for the hassle.. I'm flushing my WIP trees, deleting old stuff and forgot this change had a dependency on something that's not quite ready yet. Warner On Mon, Dec 16, 2019 at 4:12 PM pete wright wrote: > Thanks, maybe git mirror was lagging will test in a bit. > > Thanks! > -pete > > On Mon, Dec 16, 2019, 3:09 PM Warner Losh wrote: > >> Update. That version was in place for about an hour before I fixed it. >> r355815 broke it and r355818 fixed it. >> >> Warner >> >> >> On Mon, Dec 16, 2019 at 3:27 PM pete wright wrote: >> >>> here's the error i'm getting when building: >>> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:28: error: >>> expected >>> identifier >>> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >>> ^ >>> /usr/home/pete/git/freebsd/sys/sys/sysctl.h:126:18: note: expanded from >>> macro 'OID_AUTO' >>> #define OID_AUTO (-1) >>> ^ >>> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:1: error: type >>> specifier missing, defaults to 'int' [-Werror,-Wimplicit-int] >>> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >>> ^ >>> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:13: error: this >>> function declaration is not a prototype [-Werror,-Wstrict-prototypes] >>> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >>> ^ >>> 3 errors generated. >>> *** [scsi_da.o] Error code 1 >>> >>> >>> >>> might be this commit? >>> commit 5fa79c6768be78d78815156f8ecf50cb2008233f (HEAD -> master, >>> origin/master, origin/HEAD) >>> Author: imp >>> Date: Mon Dec 16 18:16:44 2019 +0000 >>> >>> Implement a system-wide limit or da and ada devices for delete. >>> >>> Excesively large TRIMs can result in timeouts, which cause big >>> problems. Limit trims to 1GB to mititgate these issues. >>> >>> Reviewed by: scottl >>> Differential Revision: https://reviews.freebsd.org/D22809 >>> >>> >>> >>> if there is any additional info needed happy to provide it. >>> >>> cheers, >>> -pete >>> >>> -- >>> pete wright >>> www.nomadlogic.org >>> @nomadlogicLA >>> _______________________________________________ >>> freebsd-current@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-current >>> To unsubscribe, send any mail to " >>> freebsd-current-unsubscribe@freebsd.org" >>> >>