From nobody Wed Apr 1 11:58:10 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fm3Qp2GwXz6Wcv5 for ; Wed, 01 Apr 2026 11:58:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fm3Qp1kh5z3JCc for ; Wed, 01 Apr 2026 11:58:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775044690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ECzsRFRrEnmwqaIU5QP1UpmKX++tjaYfm5a9O22jEb0=; b=emD9RWZQss3RdD8jLprvPG/mnQFpBgBrTpGgLHdo2btJjWt7TdHvzFo5lF6jDZ4GfUwkIn HPfKOowKbUj5eQeosHU/bpoWX1lfrnypwLtZs/ke2t6aNZhzxLDyJ6ZwBw6qL9DRv0JIWu ziwCvvOIy/weRqplrx05no28jxNw1gpcYGzDHYjOiECA7EO5o89MC1QXydqxtFBnYjCWpC gJSlGYkWSbdLPv9dvpZYlbxE4h76FaSXFgJSfYoxeEi9dpU6f+pAeQko9I0GFS1Iq3ABzT 0YDQ3Lt28d/0PbuGkuInGTaoDeNOPeCIQognX0QNKP/L+Fapl8HO/9iZ2QUXFw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1775044690; a=rsa-sha256; cv=none; b=vAH7VxqQJwU5vuBZeUgvhCi6DQUbLarrbuRqg1kH0pHzw5PTDeO3ZptqJ5D8sRtXKB062Y fVhYPrFecLa2PZEBtu7p48m2dspXH/Mo2z5hiZwhlFqHyT63Jc4quo3XhxE7WXWBNWEpRp C8SybDjrporBe0zuZuITKVNAnYQ1oxVc7pEE/N5rOTGIAYPeQGvJg9d/9/W5DVy0YuPQM8 yVofoeAmfV4OwW2JoEi9RZJsZcaxdG3TwEakQEUrfedg5J4HMfyCl/97nm1AkAl2pk8sa1 4gGr996XRl45vGU5LCgvqxm8Se8YJCm2U+zlJwwlHbMZR/kyEOUNGZ1/MGbPzw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775044690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ECzsRFRrEnmwqaIU5QP1UpmKX++tjaYfm5a9O22jEb0=; b=NE/pxCXrVQQQ7sZ17smWO1N+pfSYZbVsVoO5uZQa7PkeNbtpE9GRykIriCOIkC87FOwlcS OCJbrEMHvoXxMpoedMNbnX63fuuOtLWwWJdwOdP4fW5RItWutAT1K9c8POZaIipY1pMqYr 6LIwMk/oWDvIRyKD6AtXTUbCCa5TfgOOzOS8SPtsladzCpW3ZbS2laEgb8LAUcLf7hEkuH WHloz1xGMuWcxK+rwolwBf3SHgvcRQng6cEl0fUDcSSvSvJL4wUsU0zrLZ9SP4V2kgADRI Woxyx3EEKpTPMwUc6fAERbrbK+uvEo0FAoui+2W9LQFv2Isei8MeS3+d9Hv4TA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fm3Qp0rVKzZf for ; Wed, 01 Apr 2026 11:58:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 18573 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 01 Apr 2026 11:58:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Aymeric Wibo Subject: git: 0307db7744d4 - main - acpi_spmc: Fail probe if acpi_spmc device already attached List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: obiwac X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0307db7744d4cfe0d610ebece226dd20fdcc4ed5 Auto-Submitted: auto-generated Date: Wed, 01 Apr 2026 11:58:10 +0000 Message-Id: <69cd0852.18573.49d8a187@gitrepo.freebsd.org> The branch main has been updated by obiwac: URL: https://cgit.FreeBSD.org/src/commit/?id=0307db7744d4cfe0d610ebece226dd20fdcc4ed5 commit 0307db7744d4cfe0d610ebece226dd20fdcc4ed5 Author: Aymeric Wibo AuthorDate: 2026-04-01 11:54:57 +0000 Commit: Aymeric Wibo CommitDate: 2026-04-01 11:54:58 +0000 acpi_spmc: Fail probe if acpi_spmc device already attached We cannot have more than one SPMC device. Reviewed by: olce Approved by: olce Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D56062 --- sys/dev/acpica/acpi_spmc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c index 206d3a843f53..0c2a5d9e96a9 100644 --- a/sys/dev/acpica/acpi_spmc.c +++ b/sys/dev/acpica/acpi_spmc.c @@ -190,6 +190,11 @@ acpi_spmc_probe(device_t dev) if (ACPI_ID_PROBE(device_get_parent(dev), dev, spmc_ids, &name) > 0) return (ENXIO); + if (device_get_unit(dev) > 0) { + device_printf(dev, "shouldn't have more than one SPMC"); + return (ENXIO); + } + handle = acpi_get_handle(dev); if (handle == NULL) return (ENXIO);