From owner-svn-src-all@freebsd.org Mon Jan 22 14:30:07 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCDA8EC3B5E; Mon, 22 Jan 2018 14:30:07 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0BC867E34B; Mon, 22 Jan 2018 14:30:06 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 22826d53; Mon, 22 Jan 2018 15:30:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=xf50KYifUkOM9MVAQjwhr5b1bQk=; b=r6M4Oqui02J3niOrshzwnF7d2p9U 81WUP1YRcIndO6TMQW24ymO5NT7+yYyfLDfjLAjzalpaoHSmfMH9k0X28/CJFeCZ S3aF0+ZfAGOJgLtZEszM+2QmUCod0NL4lf4gCWE2iZGCsHj7ffOSLZ7jeSxKAnBy +wP7KNOiHKtXCwI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=al7yVU6eoXVTVEYy+s5BrmI9eQF4PItws6YjLFVqj5y2jT8fXwdYzJLP E+ttUup3l72AX2ygwmAZOR2UtgcrdPpTY/kkX2OA9xF7o1fRIP+vMFxdrqmOnabl kpFoZgOOzs+xUnfgBWPWqt0P992zGD3IgVD4jMC2/Nmrb+pMxxA= Received: from arcadia (evadot.gandi.net [217.70.181.36]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 85eaee72 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Mon, 22 Jan 2018 15:30:03 +0100 (CET) Date: Mon, 22 Jan 2018 15:30:03 +0100 From: Emmanuel Vadot To: "Poul-Henning Kamp" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-Id: <20180122153003.664e1613bbf70ab49c5c1541@bidouilliste.com> In-Reply-To: <88258.1516630050@critter.freebsd.dk> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <20180122135905.203e19ce94510854777dff63@bidouilliste.com> <88070.1516628327@critter.freebsd.dk> <20180122145117.08173be547f5dd6fef296732@bidouilliste.com> <88258.1516630050@critter.freebsd.dk> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 14:30:08 -0000 On Mon, 22 Jan 2018 14:07:30 +0000 "Poul-Henning Kamp" wrote: > -------- > In message <20180122145117.08173be547f5dd6fef296732@bidouilliste.com>, Emmanuel > Vadot writes: > > > Using the same logic as before one could have a script starting some > >pwm stuff (or simply using /etc/sysctl.conf) > > Also this is not how DT is suppose to work, if the status == > >'disabled' no driver should attach. > > That doesn't make *any* UX sense. > > "disabled" indicates that it can be enabled, and there is absolutely > no reason to force users to reboot, when all that stands between > them and using their hardware is a random setting in a file. To be more clear, disabled mean that the node should not be used. In a industrial board you will always have every usable node enabled, in the SBC world where you have a way to plug daughter card and exchange them or even use the exposed pins directly there is no way to know what the user will do so every node not used by the SBC must be disabled. This is the overlay part of DT that is responsible to enable them > Explicitly kldload'ing a device-driver is as clear a "Enable it, please" > instruction as you can get from the user. But device driver != DT node > If you want to lock down this DT-device because some other > device/pin-mux/whatever makes its use impossible, then > status should not be "disabled" but "locked" or "impossible". Feel free to talk to the DT guys. > In particular it is *horrible* UX, that you kldload a device-driver > for hardware you know is there, and it just silently doesn't do > anything. At the very least it should give a diagnostic. > > Maybe something like: > > "For no good reason this device is disabled, google for > an hour, try to come up with a device tree overlay, reboot > to install it and see if you get lucky." > > :-) > > >> > Can you please revert this part ? > >> > >> Once I find out how to get similar behaviour, ie: kldload without > >> having to reboot to load a DT-overlay. > > > > Nobody is working on that right now (that I know of). > > Let me know when it works, and I'll remove my hack then. > > In the meantime, don't load bcm283x_pwm if you don't plan on > using the PWM on GPIO12 on your RPI[23]. > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. -- Emmanuel Vadot