From owner-freebsd-stable@FreeBSD.ORG Tue Jul 11 23:04:55 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E473016A4E7 for ; Tue, 11 Jul 2006 23:04:55 +0000 (UTC) (envelope-from atanas@asd.aplus.net) Received: from pro20.abac.com (pro20.abac.com [66.226.64.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18E3043D5C for ; Tue, 11 Jul 2006 23:04:55 +0000 (GMT) (envelope-from atanas@asd.aplus.net) Received: from [216.55.129.5] (asd2.aplus.net [216.55.129.5]) (authenticated bits=0) by pro20.abac.com (8.13.6/8.13.6) with ESMTP id k6BN4q3T076226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Jul 2006 16:04:53 -0700 (PDT) (envelope-from atanas@asd.aplus.net) Message-ID: <44B43029.1060309@asd.aplus.net> Date: Tue, 11 Jul 2006 16:11:37 -0700 From: Atanas User-Agent: Thunderbird 1.5.0.4 (Macintosh/20060516) MIME-Version: 1.0 To: Matthias Andree References: <44B40863.9060403@asd.aplus.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 1.47 (SPF_SOFTFAIL) Cc: freebsd-stable@freebsd.org Subject: Re: portupgrade bug: -M no longer works after v2.1.0 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2006 23:04:56 -0000 Matthias Andree said the following on 7/11/06 1:48 PM: > Atanas writes: > >> Recent portupgrade versions no longer obey the -M command line switch, >> i.e. any optional arguments to be prepended to each make command. >> >> How to reproduce: >> >> # portinstall -M "APACHE_HARD_SERVER_LIMIT=1024" www/apache13 >> ... >> ===> src/ap >> cc -c -I../os/unix -I../include -I/usr/local/include -funsigned-char >> -O2 -fno-strict-aliasing -pipe >> -DDOCUMENT_LOCATION=\"/usr/local/www/data\" >> -DDEFAULT_PATH=\"/bin:/usr/bin:/usr/local/bin\" -DHARD_SERVER_LIMIT=512 >> `../apaci` ap_cpystrn.c >> ... >> >> Note the -DHARD_SERVER_LIMIT=512 above. > > Does it work if you type (you can omit the env in /bin/sh, bash, (pd)ksh > and other Bourne-like shells): > > env APACHE_HARD_SERVER_LIMIT=1024 portinstall www/apache13 > Of course it would, but this just bypasses the problem. There are other ways to work this around as well - like not using portupgrade at all and building everything with make. The problem is that there's a bug introduced by some of the recent portupgrade versions that changes its documented behavior. The '-M' switch in partucular no longer works, thus causing any existing port/package installation scripts depending on that switch to build packages with incorrect optional parameters. It's not a problem with a particular port. The www/apache13 port was given just as example how to reproduce the bug. This affects _all_ ports when installed/upgraded/built via portupgrade and when the '-M' switch is used. > (Isn't it time to migrate to a newer Apache version anyways? 8-) ) > (This is a long subject and kind of off-topic here. My short answer is no, or not yet. In some environments there are still legitimate reasons to use 1.3) Regards, Atanas