Date: Sat, 1 Dec 2012 02:59:48 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Taku YAMAMOTO <taku@tackymt.homeip.net> Cc: freebsd-current@freebsd.org, Andriy Gapon <avg@freebsd.org> Subject: Re: A suspicious warning in sys/boot/zfs/zfsimpl.c Message-ID: <CAGH67wQ3BtyaYZNGxT_UW%2Be=CVR0V6V%2BZc027bDgDNv6fK66eg@mail.gmail.com> In-Reply-To: <20120703102142.6554b10e.taku@tackymt.homeip.net> References: <20120703102142.6554b10e.taku@tackymt.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 2, 2012 at 6:21 PM, Taku YAMAMOTO <taku@tackymt.homeip.net> wro=
te:
> When I built the world as of r237813, clang reported a warning which
> caught my attention.
>
> =3D=3D=3D> sys/boot/zfs (all)
> clang -O2 -pipe -march=3Dpentium4 -DBOOTPROG=3D\"zfsloader\" -I/usr/src/=
sys/boot/zfs/../common -I/usr/src/sys/boot/zfs/../.. -I. -I/usr/src/sys/boo=
t/zfs/../../../lib/libstand -I/usr/src/sys/boot/zfs/../../cddl/boot/zfs -ff=
reestanding -mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mn=
o-sse2 -mno-sse3 -msoft-float -Wformat -Wall -DNDEBUG -std=3Dgnu99 -Qunused=
-arguments -c /usr/src/sys/boot/zfs/zfs.c -o zfs.o
> In file included from /usr/src/sys/boot/zfs/zfs.c:48:
> /usr/src/sys/boot/zfs/zfsimpl.c:2033:19: warning: array index 264 is past=
the end of the array (which contains 192 elements) [-Warray-bounds]
> memcpy(path, &dn.dn_bonus[sizeof(znode_ph=
ys_t)],
> ^ ~~~~~~~~~~~~~~~=
~~~~~
> /usr/src/sys/boot/zfs/../../cddl/boot/zfs/zfsimpl.h:788:2: note: array 'd=
n_bonus' declared here
> uint8_t dn_bonus[DN_MAX_BONUSLEN - sizeof (blkptr_t)];
> ^
>
> I don't have a zfs-powered machine, so I'm not sure whether this
> warning is false-positive or not.
I'm seeing the same warnings trying to build HEAD r242903 with
clang on amd64. Andriy CCed.
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wQ3BtyaYZNGxT_UW%2Be=CVR0V6V%2BZc027bDgDNv6fK66eg>