From owner-freebsd-bugs@FreeBSD.ORG  Tue Jan  4 12:30:30 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C05C116A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  4 Jan 2005 12:30:30 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8B15043D1D
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  4 Jan 2005 12:30:30 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j04CUUXi025971
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 4 Jan 2005 12:30:30 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j04CUULH025968;
	Tue, 4 Jan 2005 12:30:30 GMT
	(envelope-from gnats)
Date: Tue, 4 Jan 2005 12:30:30 GMT
Message-Id: <200501041230.j04CUULH025968@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Ceri Davies <ceri@submonkey.net>
Subject: Re: bin/75786: typo and useless part in /etc/pccard_ether
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Ceri Davies <ceri@submonkey.net>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jan 2005 12:30:30 -0000

The following reply was made to PR bin/75786; it has been noted by GNATS.

From: Ceri Davies <ceri@submonkey.net>
To: Radko Keves <rado@daemon.sk>
Cc: FreeBSD Gnats Submit <freebsd-gnats-submit@FreeBSD.org>
Subject: Re: bin/75786: typo and useless part in /etc/pccard_ether
Date: Tue, 4 Jan 2005 12:22:23 +0000

 On Tue, Jan 04, 2005 at 01:19:41PM +0100, Radko Keves wrote:
 > Tue, Jan 04, 2005 at 12:10:41PM +0000, Ceri Davies said that
 > > On Tue, Jan 04, 2005 at 01:01:28PM +0100, Radko Keves wrote:
 > > > Tue, Jan 04, 2005 at 11:58:14AM +0000, Ceri Davies said that
 > > > > On Tue, Jan 04, 2005 at 09:41:59AM +0000, Radko Keves wrote:
 > > > > 
 > > > > > -case ${pccard_ifconfig} in
 > > > > > -[Nn][Oo] | '')
 > > > > > -       expr "${removable_interfaces}" : ".*${interface}" > /dev/null || exit 0
 > > > > > -       ;;
 > > > > > -*)
 > > > > > -       # Backward compatible
 > > > > > -       eval ifconfig_${interface}=\${pccard_ifconfig}
 > > > > > -       ;;
 > > > > > -esac
 > > > > 
 > > > > This doesn't look useless.
 > > > > 
 > > > > Could you explain your rationale a bit more please?
 > > > 
 > > > in this moment:
 > > > /etc/pccard_ether $device-name <start|stop>
 > > > 
 > > > isn't working, but after my changes is.
 > > > 
 > > > Please run /etc/pccard_ether $device-name <start|stop>
 > > > 
 > > > and you will see.
 > > 
 > > Do you have removable_interfaces set appropriately in /etc/rc.conf?
 > > If you believe so, please post your rc.conf.
 > 
 > I'm not sure what do you mean with removable interface, and where is the
 > your point, but i'm sure /etc/pccard_ether $device-name <start|stop> is
 > not working.
 > 
 > $ grep ifconfig /etc/rc.conf
 > ifconfig_bge0="DHCP"
 > 
 > I'm not talking about "devd", but about setting up dhcp with
 > pccard_ether script.
 > 
 > but:
 > $ grep -i removable /etc/defaults/rc.conf
 > removable_interfaces="" # Removable network interfaces for
 > /etc/pccard_ether.
 > $ 
 > $ grep -i removable /etc/rc.conf         
 > $ 
 > 
 > After i specified removable_interface:
 > (sorry i didn't know it is mandatory for pccard_ether script)
 > $ grep -i removable /etc/rc.conf         
 > removable_interfaces="bge0" # Removable network
 
 OK, that's one down. You must set that.
 
 > and run (original script):
 > $ sudo /etc/pccard_ether stop
 > shift: can't shift that many
 > $ 
 > 
 > so still i'm not sure about $1 shifter twice.
 
 You're not passing in the interface name - the correct invocation is:
 	/etc/pccard_ether bge0 stop
 
 > Sorry, if i didn't specified it before.
 
 No problem.
 
 Ceri