Date: Sun, 5 Feb 2017 18:58:11 +0000 (UTC) From: Jan Beich <jbeich@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r433445 - head/multimedia/kodi/files Message-ID: <201702051858.v15IwB2I022471@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jbeich Date: Sun Feb 5 18:58:10 2017 New Revision: 433445 URL: https://svnweb.freebsd.org/changeset/ports/433445 Log: multimedia/kodi: unbreak with clang 4.0 RssReader.cpp:269:19: error: ordered comparison between pointer and zero ('TiXmlElement *' and 'int') while (itemNode > 0) ~~~~~~~~ ^ ~ RssReader.cpp:273:22: error: ordered comparison between pointer and zero ('TiXmlNode *' and 'int') while (childNode > 0) ~~~~~~~~~ ^ ~ PR: 216075 Submitted by: tcberner Approved by: maintainer timeout (2 weeks) Added: head/multimedia/kodi/files/patch-xbmc_utils_RssReader.cpp (contents, props changed) Added: head/multimedia/kodi/files/patch-xbmc_utils_RssReader.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/multimedia/kodi/files/patch-xbmc_utils_RssReader.cpp Sun Feb 5 18:58:10 2017 (r433445) @@ -0,0 +1,18 @@ +Fix bogus pointer comparisons. + +--- xbmc/utils/RssReader.cpp.orig 2017-01-21 21:11:51 UTC ++++ xbmc/utils/RssReader.cpp +@@ -266,11 +266,11 @@ void CRssReader::GetNewsItems(TiXmlEleme + if (m_tagSet.empty()) + AddTag("title"); + +- while (itemNode > 0) ++ while (itemNode) + { + TiXmlNode* childNode = itemNode->FirstChild(); + mTagElements.clear(); +- while (childNode > 0) ++ while (childNode) + { + std::string strName = childNode->ValueStr(); +
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702051858.v15IwB2I022471>