From nobody Wed Feb 25 06:22:56 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fLPfR327sz6Scw8 for ; Wed, 25 Feb 2026 06:23:11 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fLPfR1RcRz3CVX for ; Wed, 25 Feb 2026 06:23:11 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-824ba8f0acaso3621511b3a.1 for ; Tue, 24 Feb 2026 22:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772000589; x=1772605389; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IcdZiYI2qFTtonIAFGMm6YjYnrEMwg5pce4IEpGv+5I=; b=GoZz2Q0dHuwxCMkF4LhLNOC+xhvNbWW6BW/rtyMlneiJxwOv84TjK57c/J9GSMe++r 37f7ZxzEem4F7U0WNyDPWZ3YDLak6V7NlMJvzd3k4Tej+dWQulOp4aCXo4trMONBl2Zh 7xEFSkTEtjA+WZ4GzUMDMwAwfoFMvnO0yRo7ZQSIcSTNQZ0PHLpI0ArZj1aTkcjHPtUk a41jam8Zkc7RmoV7KEJN9Aom3T/UtHrF+Y4WlB/kBYL/eNVH22GQHiZYnvJi6zxJcfMp v7b1GdykB1vJ3LkGnZGH06A/iRdC7vvHiCSqd0Bg7SEWRXVlgmBW4bS51eSR4kO3IQqU KFcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772000589; x=1772605389; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IcdZiYI2qFTtonIAFGMm6YjYnrEMwg5pce4IEpGv+5I=; b=f7Be2/Y0jfFz8jJ3BQfkLVpiKQqtKExLIuYgkaraiEfIAdQErjkd+hzcNTY2VJIABI vXQXhmRBrRVaISUOOAJ9ypmJGmgqJg7QWtxHLeU0fzGt9HfCOWM02VDsHmNFEVl9Yjrw Baf+STfPwrE4PNfPKBQcq8sI0iu2412u8wWluqJ5HAPNHoiSUvd1le+WdL7pwr0dxazD +TGJzfu7LU8INVES9tEdkUibUP0i+BdLmEeqV/jr2rNGdMXXe0rvTiRJSWalmmYE7irZ RS7e/QJWbxE77Tig0/SGIfIcFDEy4dhbsnEaLEccAMwgBteAPirjzT8jfeEm8ORgBiRY YG4Q== X-Forwarded-Encrypted: i=1; AJvYcCUKL0FfjkvA5UCJ6nGtgnfIUHvOgC/wx92dMuWlk13K4ya/i0hRhLA97aZ2rUXoJbPDCnG8Rye8W1Dnbaa/dBZPK7Nb48Jswd8=@freebsd.org X-Gm-Message-State: AOJu0YxrLUB6Bq5mRzSPB0tPRswEbBnZhZ4bBpy/UELBUHQ+pmeGT/Aa PSG/5Riem4onO/FfMT9P3xNsdyFp0LCWxHdMpjasu+qH3yb6rUJLfJzk X-Gm-Gg: ATEYQzxO0Vxt37fqXU2IbPWZYY2/56ahtkjIEPP8WoSQAFwcp3rPLdFoI5w+Tc8266T x++MUGLQ0royquOXTSoKCAKhboh/vfvb/9HZyErlTJoD+2SRwKMrrN0waVlywkgHn+85PAJ0DzF AL/BPqXE6SV+/EqYGFPC81VO8nFJYlW+0xPaK7KJjeVEeigv+lF+6yKC0p07Yryr1PH+/8nOwkv J9fFuS2TWt0iBZCd5Wc2pdurbbvJevN9I4qmYrA9Vph9C3labBrKjJnrm9hMJtFZhkYUsqcXXla 0tbpjzclVVLR1Ggb7gXAtVSgC9idCCDh8uf4JrUJpGW0FNvc0WLGhS4KLk4uQHEDY4Uzdiuy49m NyMusToeL9xZH8CZt6M/7hf/2AfmNH9vYWPMNv0zZJKEvoOGxaydinTcyyeStBUYGyzWd20bO00 xl0qsreUIG8dqVRZtDdVv6ysKTDhzyxUMZtq9jE6ruidlueH3JZ533 X-Received: by 2002:a05:6a00:3a1d:b0:81e:7496:f826 with SMTP id d2e1a72fcca58-826da9f08c1mr13054461b3a.31.1772000588857; Tue, 24 Feb 2026 22:23:08 -0800 (PST) Received: from smtpclient.apple ([176.100.43.172]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd8ba11bsm12578956b3a.50.2026.02.24.22.23.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2026 22:23:08 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_4BA3F2B1-4A4D-4B78-84AB-B941736561C8"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.3\)) Subject: Re: git: 887f0f125fd1 - stable/14 - Revert "GoogleTest: import 1.17.0" From: "Enji Cooper (yaneurabeya)" In-Reply-To: Date: Tue, 24 Feb 2026 22:22:56 -0800 Cc: Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-branches@freebsd.org" Message-Id: <30C3C506-3327-4605-8D6C-237393D6D676@gmail.com> References: <699a9186.32e99.543fe4bb@gitrepo.freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.3826.700.81.1.3) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fLPfR1RcRz3CVX X-Spamd-Bar: ---- --Apple-Mail=_4BA3F2B1-4A4D-4B78-84AB-B941736561C8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Feb 24, 2026, at 7:30=E2=80=AFAM, John Baldwin = wrote: >=20 > On 2/22/26 00:17, Enji Cooper wrote: >> The branch stable/14 has been updated by ngie: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D887f0f125fd1282c8054b402ad72af37= 1a9f5dec >> commit 887f0f125fd1282c8054b402ad72af371a9f5dec >> Author: Enji Cooper >> AuthorDate: 2026-02-22 05:17:40 +0000 >> Commit: Enji Cooper >> CommitDate: 2026-02-22 05:17:40 +0000 >> Revert "GoogleTest: import 1.17.0" >> This reverts commit = 227baf32d26360137492b108aba06c6a54c0949b. >=20 > Please include the "why" in commit logs when reverting. I (nor any > other readers) have any idea why you reverted these commits. Will do next time :/. I reverted these changes because some of the compiler changes made on = main couldn=E2=80=99t be backported without potentially breaking how C++ = binaries are built, resulting in potentially unexpected breakage on = stable/14. I might retry it in a future cherry-pick after additional = testing, but for now I pulled the changes out to ensure behavior isn=E2=80= =99t dramatically changed on the branch. Thank you so very much for bringing this up. -Enji= --Apple-Mail=_4BA3F2B1-4A4D-4B78-84AB-B941736561C8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmelUAACgkQGpE5DjPs NJiZSQ//e1L8BZUMEbpjJHQLeZ1DNBrPNxghEjtHFs0gJlkWdSN4h1kdP79nBI0t 0B2IJ96nNk4+kW4JoWuGkgaGIlS2toshmtYj3ZC1/ZFaNqJoN4b0pvBDPjEuAvI6 RMQCtzne41riS2pCFth/X8cVua/mTIlyU34h5nwlykAHlaY0S3w9fYSe+YBx21DY HBG5zLBQKpKOo96+3OyguOCsv7jH72NMxdqPSjJTHtqPGThHw1IbaeQ2d3vQh6WB Vc28AkSBmhBFUpQu8T+SRFoM7IU3hxTIgLCTEQY7H+SRx3aF5jkQ2D/LfxYEK1ZS Uq6b6JQddWaPGp/DtcGUW/PWZ2cFUY7YI9zTnCGRNWqK4uPSX67SWooQFVRpuwZS Jm6J+IfdRn/rLTjG4UhKFV5YUR+6TlNALKSJdwxYEIQF+WQvqWYVq1vLwCirdI5Q 4NXq6nnI1v40zMbquBy3r0Mj1tNRnaY/5aRzISacscilfmauksobwNKk7v5IlacV Q7otjbGPoREOCxcgvnsnBLoPqfD/+l9kRrOVhhDiMRg3ATtw5QhvS2yqdYd5ql0e xjCy1azlHMW2iNIw/bECdjLYMLeYeQ7wbRtXlKXzms8n/W1Ests4sqkxAlPKn+/I dJGk7hvFZPThgDWzz2SiNEE+STumrrtGKQoNEtG/QpmtJnBw8jk= =h2lo -----END PGP SIGNATURE----- --Apple-Mail=_4BA3F2B1-4A4D-4B78-84AB-B941736561C8--