Date: Fri, 4 Aug 2006 09:52:31 +0200 From: Stefan Farfeleder <stefanf@FreeBSD.org> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: cvs-src@FreeBSD.org, Stefan Farfeleder <stefanf@FreeBSD.org>, pdeuskar@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Message-ID: <20060804075230.GD89735@wombat.fafoe.narf.at> In-Reply-To: <20060804074657.GT97316@comp.chem.msu.su> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > sweeps separate from actual code changes even if they are tiny. > > > Changing style(9) shouldn't alter the binary code produced, and > > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > > Of course, changing line numbers will affect debug info, but the > > > latter can be strip(1)'ed. In the case under discussion, I'd compare > > > if_em.o with its former version to make sure no code changed. > > > > It will produce different code if __LINE__ is used. > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > Fortunately, they are not widely used in src/, AFAIK. Not directly, but through all kinds of assertion macros. Stefan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060804075230.GD89735>