From owner-freebsd-hackers@FreeBSD.ORG Sun Oct 28 03:46:30 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 14B2C454 for ; Sun, 28 Oct 2012 03:46:30 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm35-vm6.bullet.mail.gq1.yahoo.com (nm35-vm6.bullet.mail.gq1.yahoo.com [98.136.216.189]) by mx1.freebsd.org (Postfix) with ESMTP id BCF3F8FC12 for ; Sun, 28 Oct 2012 03:46:29 +0000 (UTC) Received: from [98.137.12.175] by nm35.bullet.mail.gq1.yahoo.com with NNFMP; 28 Oct 2012 03:46:23 -0000 Received: from [208.71.42.198] by tm14.bullet.mail.gq1.yahoo.com with NNFMP; 28 Oct 2012 03:46:23 -0000 Received: from [127.0.0.1] by smtp209.mail.gq1.yahoo.com with NNFMP; 28 Oct 2012 03:46:23 -0000 X-Yahoo-Newman-Id: 166537.9987.bm@smtp209.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: pZOXLyAVM1nNcyx.r.jx1zHznBvg33tiuoJRrpOn9o126yJ 7xPGZsav4f3S0at6yIMyLiV_BWmrXqN5KksgaCsSxZdE0eEyJw9jEwf1xKLd Vwmyg9ys6AyWZmsv23PiSUlPUIAmClLZeZv_dyhsLtOyEE_R0hSrD2bqS3cQ 6RhB1lghIbX3ysmDNEBtP3CQBBW7ndUfcqmCb30NDRYDy4VkxzswqlImMyc9 xHj1jw2q5T9AFAQ.0C0UuTLY_aBVF8I_EAmkQe9I81rXko6E66I9Oes_922a nN9BkAdkRFL093yPfAUNz2Bw288HI_xMG5iJpq09JYPXrlDtr29T1ROE2AeG Hh55pyh.v9cqU4B4WebruSJ5FcAnlqwEkI4iCWlOtqvafSMVZO5DudFUHbmQ mufEJr5QNWricHG_1GxVuTASoGrhAg5vgAgHqlPqjGyux07z9YgtyFWymbkD XmeA_50qRFjA4oivZFemAVZLIvB_HnQ-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Received: from [192.168.10.103] (pfg@200.118.157.7 with plain) by smtp209.mail.gq1.yahoo.com with SMTP; 27 Oct 2012 20:46:22 -0700 PDT Message-ID: <508CAA8F.2040701@FreeBSD.org> Date: Sat, 27 Oct 2012 22:46:23 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120621 Thunderbird/13.0.1 MIME-Version: 1.0 To: hiren panchasara Subject: Re: Porting patch(1) from NetBSD to FreeBSD (was Re: FreeBSD in Google Code-In 2012? You can help too!) References: <508C61C1.8090109@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Chris Rees , freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2012 03:46:30 -0000 Hi; On 10/27/2012 22:08, hiren panchasara wrote: > > > On Sat, Oct 27, 2012 at 3:35 PM, Pedro Giffuni > wrote: > > Hello Hiren; > > > > On 10/27/2012 16:48, hiren panchasara wrote: > ... > > > This is great news Hiren, Thanks! > > > The stress test for this utility is the ports tree but before that > we have to > know what will change. > > Thanks Pedro! > I will have a lot of questions as I am a newbie here. :-) > > > What needs to be done is: > > 1- Compare the options between our old patch and the new BSD patch. > > Will do. > > 2- Document this in FreeBSD's wiki. > > I think this needs to be done when we are done deciding on diffs and > how the changes look, right? > Also, I do not think I have write access to the wiki. Well, I am hoping that we don't have to do any hacking on patch to be acceptable but having a table like this would be nice: http://wiki.freebsd.org/SOC2010BenFiedler This is mandatory though, just planning ahead. > > 3- Prepare a port for testing. > > Does this need to be a port? I thought this would live in > /src/usr.bin/patch. > Also, I believe this will co-exist with current gnu patch(1). Is that > a right assumption? > We like to be safe and having it in the ports tree makes it easier to test it on all FreeBSD versions and platforms before it finds it's way into the base system. I know this sounds like a long tedious process but we have a reputation to take care of ;). Creating a new port of this is really easy though; you can probably start with the bsd sort port as a template and check porter's handbook if there is any doubt. Let us know if you need to a place to put of the tarball. Pedro.