From owner-freebsd-net@FreeBSD.ORG  Tue Oct  7 13:29:55 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 782B910656A8;
	Tue,  7 Oct 2008 13:29:55 +0000 (UTC)
	(envelope-from ganbold@micom.mng.net)
Received: from publicd.ub.mng.net (publicd.ub.mng.net [202.179.0.88])
	by mx1.freebsd.org (Postfix) with ESMTP id 307358FC2C;
	Tue,  7 Oct 2008 13:29:55 +0000 (UTC)
	(envelope-from ganbold@micom.mng.net)
Received: from [202.179.21.141] (helo=devil.micom.mng.net)
	by publicd.ub.mng.net with esmtpa (Exim 4.69 (FreeBSD))
	(envelope-from <ganbold@micom.mng.net>)
	id 1KnCdM-0006EK-Q6; Tue, 07 Oct 2008 21:29:52 +0800
Message-ID: <48EB6450.9050004@micom.mng.net>
Date: Tue, 07 Oct 2008 21:29:52 +0800
From: Ganbold <ganbold@micom.mng.net>
User-Agent: Thunderbird 2.0.0.16 (X11/20080901)
MIME-Version: 1.0
To: freebsd-ipfw@freebsd.org
References: <48DA1B65.8030106@micom.mng.net>
In-Reply-To: <48DA1B65.8030106@micom.mng.net>
X-Enigmail-Version: 0.95.6
OpenPGP: id=78F6425E
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org
Subject: Re: ipfw port lookup table patch for review
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Oct 2008 13:29:55 -0000

Hi,

I have just made the patches that use arrays for port entries.

It is under the same directory:
http://people.freebsd.org/~ganbold/ipfw_port_table/

Array version (each array can have IPFW_TABLES_MAX entries):
http://people.freebsd.org/~ganbold/ipfw_port_table/ipfw_port_table_array_unsorted/

List version is still at:
http://people.freebsd.org/~ganbold/ipfw_port_table/ipfw_port_table_list_unsorted/

thanks,

Ganbold


Ganbold wrote:
> Hi,
>
> I thought it might be useful to have port lookup table similar to 
> existing IP lookup table
> in ipfw and I have made patch for that.
>
> The downside of the patch so far I'm seeing is the port entries are in 
> linked list
> (no limitation yet, memory overhead), not sorted and it uses linear 
> search
> to match (could be slow when lot of entries).
>
> Just after I've made the patch I saw
> http://www.freebsd.org/cgi/query-pr.cgi?pr=121807&cat= . :(
>
> I agree with PR's reply however for small number of port entries I 
> thought
> this functionality is quite useful. It gives benefit like no need to 
> modify existing rule,
> adding/deleting port entries is easy.
>
> I did some small tests and it seems like working.
>
> Patches are at:
> http://people.freebsd.org/~ganbold/ipfw_port_table/
>
> The output of some usage samples is at:
> http://people.freebsd.org/~ganbold/ipfw_port_table/ipfw_port_table_usage_sample.txt 
>
>
> Patches can be successfully applied to CURRENT. Didn't test RELENG_7 
> due to
> no RELENG_7  PC :)
> Please let me know your thoughts. I'm happy to discuss to improve the 
> patch.
> Correct me if I'm doing something wrong here.
>
> thanks,
>
> Ganbold
>
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
>
>
>