From owner-freebsd-ports@freebsd.org Mon Aug 3 21:55:58 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D19FE3A85D1 for ; Mon, 3 Aug 2020 21:55:58 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BLBXY2kmGz4RSm; Mon, 3 Aug 2020 21:55:57 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp.greenhost.nl ([213.108.110.112]) by smarthost1.greenhost.nl with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1k2iR0-0006WE-7a; Mon, 03 Aug 2020 23:55:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=klop.ws; s=mail; h=In-Reply-To:Message-ID:From:Content-Transfer-Encoding:MIME-Version: Cc:Date:References:Subject:To:Content-Type:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lfFFtISLCmtSESDnAkT0S0Tkz2Kh+ReCGOih8xYGGCw=; b=Ud3kO4wh0K/dp3V/KxdcLDVlhV Vt2ZdsS+oYMxzhGYTNx3ydRiQ6EGyJ9UtGAFG5c96sASjRWS+CqzwB/2jq7AvUWTgxQGeDdXFeUOB DBtNgQX3KG3JfL2YlmGxlYTNSVKzvEI21qWY7Dn+9mcEnvNo71z3cspgiswABokoGMts=; Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: freebsd-ports@freebsd.org Subject: Re: devel/sigar breakage on 13-current (fd_lastfile) References: Date: Mon, 03 Aug 2020 23:55:50 +0200 Cc: "Mateusz Guzik" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Ronald Klop" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.16 (FreeBSD) X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1 X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: / X-Spam-Score: -0.4 X-Spam-Status: No, score=-0.4 required=5.0 tests=ALL_TRUSTED, BAYES_50, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF autolearn=disabled version=3.4.2 X-Scan-Signature: 788438cbfdc4dc137ce560360a3a99c7 X-Rspamd-Queue-Id: 4BLBXY2kmGz4RSm X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=klop.ws header.s=mail header.b=Ud3kO4wh; dmarc=none; spf=pass (mx1.freebsd.org: domain of ronald-lists@klop.ws designates 195.190.28.88 as permitted sender) smtp.mailfrom=ronald-lists@klop.ws X-Spamd-Result: default: False [-2.31 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; R_DKIM_ALLOW(-0.20)[klop.ws:s=mail]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:195.190.28.64/27]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[klop.ws]; NEURAL_HAM_LONG(-1.03)[-1.028]; RWL_MAILSPIKE_GOOD(0.00)[195.190.28.88:from]; DKIM_TRACE(0.00)[klop.ws:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[195.190.28.88:from]; NEURAL_HAM_SHORT(-0.29)[-0.287]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:47172, ipnet:195.190.28.0/24, country:NL]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2020 21:55:58 -0000 On Sun, 02 Aug 2020 15:50:41 +0200, Ronald Klop wrote: > Hi, > > I noticed cassandra3/4 is not build on 13-current. It does build on 11 > and 12. > The cause is breakage in the devel/sigar port on 13-current. It is a > fairly recent breakage. > > works: > http://beefy18.nyi.freebsd.org/data/head-amd64-default/p541901_s363088/logs/sigar-1.7.3_2.log > > broken: > http://beefy18.nyi.freebsd.org/data/head-amd64-default/p543559_s363627/logs/errors/sigar-1.7.3_2.log > > The error seems to be in a missing sys/filedesc.h include. This is a big > guess of my side. > darwin_sigar.c:1968:27: error: no member named 'fd_lastfile' in 'struct > filedesc' > procfd->total = filed.fd_lastfile; > > I noticed the working build is in Jail OSVERSION: 1300101 and the broken > one is in Jail OSVERSION: 1300101. > I'm wondering if it is possible to get a more fine grained version nr of > the working/broken version. And while I'm typing this I see that the > URLs contain s363088 and s363627. Is this the OS revision? > > > If somebody knows the fix please go ahead. I did not make a PR yet. > Building and setting up proper jails/poudrieres on my home machine will > take quite some time. > > Regards, > Ronald. I found this commit to be to culprit. https://svnweb.freebsd.org/base?view=revision&revision=363214 The code did "filed.fd_lastfile". This was retrieved by reading kvm. Current code should do fdlastfile(&filed), but the linker can't find the method. I think because the method is defined in the kernel. What is the best way to retrieve this value in userland? Regards, Ronald.