Date: Wed, 16 May 2012 14:02:20 +0100 From: Attilio Rao <attilio@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: FreeBSD-Current <freebsd-current@freebsd.org> Subject: Re: wdog_kern_pat: liberate from SW_WATCHDOG Message-ID: <CAJ-FndAseDJK=GbEyrCui76TMm%2BmwKmP2bNxRqPT9DRGaeP4dw@mail.gmail.com> In-Reply-To: <4FB3A2DB.5000805@FreeBSD.org> References: <4FB36F41.9070101@FreeBSD.org> <CAJ-FndC%2B4Cuxb9GdzDnRdebGJ=Co0dnNk7aLGx8oD06z%2B9PWig@mail.gmail.com> <4FB3A2DB.5000805@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2012/5/16, Andriy Gapon <avg@freebsd.org>: > on 16/05/2012 15:37 Attilio Rao said the following: >> 2012/5/16, Andriy Gapon <avg@freebsd.org>: >>> >>> I would like to commit something like the following patch. >>> I think that in-kernel watchdog patting during crash dump is useful with >>> hardware watchdogs too. The code seems to work fine here. >>> In fact, I am not sure why wdog_kern_pat was originally tied to >>> SW_WATCHDOG. >> >> I didn't think I tested this with any hw watchdog. >> Which one you are using for tests? > > amdsbwd and ichwd > >> BTW, can you please skip adding the white lines? > > I thought that those calls were quite significant to be emphasized by > spacing. I don't think this is the right thing to do style-wise. But it is up to you. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndAseDJK=GbEyrCui76TMm%2BmwKmP2bNxRqPT9DRGaeP4dw>