From owner-freebsd-current@FreeBSD.ORG  Wed May 16 13:02:22 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 41220106566B;
	Wed, 16 May 2012 13:02:22 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com
	[209.85.217.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 8757F8FC0A;
	Wed, 16 May 2012 13:02:21 +0000 (UTC)
Received: by lbon10 with SMTP id n10so674331lbo.13
	for <multiple recipients>; Wed, 16 May 2012 06:02:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=gMFOjk6FAP9U0VtUQq/VG3rCaSvSAn4RbEUgrEddVZ8=;
	b=DmCQ375A1C0557oIfB71L8wbSPa65UkjtaydkBk62EF4VRANfsltTGzi8YHS8w9oux
	bjvIOiQMj6jjjE/S7BKG/8QoAfgAu9esa1IK1LT6WHRek+i3AtiYHWnxo7m7GwHJbA5E
	8TKjuAtfWj3iurZHYgHBx75agro37aOf3JTNUxlPSUttpo8gHsVHrgpnFL6Na1WxpKjs
	Z6k8M9eO6IIs7WCBCy/UohrvgRxcGat1bfkaQ2I64Rbd4+BRyvbI1lClj9LkTbGOC4BA
	zpmWFaututIxx8wcW/s/gwd9hRw+JAFU6D9WJiR8IFMOVPwcsB96fxKWGnFDcG8DS9UX
	eAAw==
MIME-Version: 1.0
Received: by 10.152.132.166 with SMTP id ov6mr3081336lab.35.1337173340337;
	Wed, 16 May 2012 06:02:20 -0700 (PDT)
Sender: asmrookie@gmail.com
Received: by 10.112.27.65 with HTTP; Wed, 16 May 2012 06:02:20 -0700 (PDT)
In-Reply-To: <4FB3A2DB.5000805@FreeBSD.org>
References: <4FB36F41.9070101@FreeBSD.org>
	<CAJ-FndC+4Cuxb9GdzDnRdebGJ=Co0dnNk7aLGx8oD06z+9PWig@mail.gmail.com>
	<4FB3A2DB.5000805@FreeBSD.org>
Date: Wed, 16 May 2012 14:02:20 +0100
X-Google-Sender-Auth: y_sacABeQt5TG-IFKsW4iCJCDZo
Message-ID: <CAJ-FndAseDJK=GbEyrCui76TMm+mwKmP2bNxRqPT9DRGaeP4dw@mail.gmail.com>
From: Attilio Rao <attilio@freebsd.org>
To: Andriy Gapon <avg@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: FreeBSD-Current <freebsd-current@freebsd.org>
Subject: Re: wdog_kern_pat: liberate from SW_WATCHDOG
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 May 2012 13:02:22 -0000

2012/5/16, Andriy Gapon <avg@freebsd.org>:
> on 16/05/2012 15:37 Attilio Rao said the following:
>> 2012/5/16, Andriy Gapon <avg@freebsd.org>:
>>>
>>> I would like to commit something like the following patch.
>>> I think that in-kernel watchdog patting during crash dump is useful with
>>> hardware watchdogs too.  The code seems to work fine here.
>>> In fact, I am not sure why wdog_kern_pat was originally tied to
>>> SW_WATCHDOG.
>>
>> I didn't think I tested this with any hw watchdog.
>> Which one you are using for tests?
>
> amdsbwd and ichwd
>
>> BTW, can you please skip adding the white lines?
>
> I thought that those calls were quite significant to be emphasized by
> spacing.

I don't think this is the right thing to do style-wise. But it is up to you.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein