From owner-freebsd-current  Thu Feb 18  8:57: 1 1999
Delivered-To: freebsd-current@freebsd.org
Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141])
	by hub.freebsd.org (Postfix) with ESMTP id 28DE011754
	for <FreeBSD-current@FreeBSD.ORG>; Thu, 18 Feb 1999 08:56:55 -0800 (PST)
	(envelope-from nate@mt.sri.com)
Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100])
	by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id JAA00972;
	Thu, 18 Feb 1999 09:56:54 -0700 (MST)
	(envelope-from nate@rocky.mt.sri.com)
Received: by mt.sri.com (SMI-8.6/SMI-SVR4)
	id JAA09277; Thu, 18 Feb 1999 09:56:51 -0700
Date: Thu, 18 Feb 1999 09:56:51 -0700
Message-Id: <199902181656.JAA09277@mt.sri.com>
From: Nate Williams <nate@mt.sri.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: Jun Kuriyama <kuriyama@sky.rim.or.jp>
Cc: FreeBSD-current <FreeBSD-current@FreeBSD.ORG>
Subject: Re: Error handling for src/usr.sbin/pccard/pccardc/*
In-Reply-To: <36CC2F98.2E3C8A56@sky.rim.or.jp>
References: <36C56288.D80AAC1E@sky.rim.or.jp>
	<199902131628.JAA18436@mt.sri.com>
	<36CC2F98.2E3C8A56@sky.rim.or.jp>
X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> > > @@ -138,9 +138,9 @@
> > >  usage(msg)
> > >       char   *msg;
> > >  {
> > > -     warnx("enabler: %s", msg);
> > > +     fprintf(stderr, "enabler: %s\n", msg);
> > >       fprintf(stderr,
> > > -"usage: pccardc enabler slot driver [-m addr size] [-a iobase] [-i irq]\n");
> > > +"Usage: enabler slot driver [-m addr size] [-a iobase] [-i irq]\n");
> > 
> > The usage really is 'pccardc enabled', not 'enabler', so this should
> > stay, or at least converted to use argv[0] to be consistent with
> > the other changes.
> 
> As Philippe Charnier said, I'll keep last line as original.  But it
> seems
> replacing warnx with fprintf(stderr, ) is reasonable, right?
> 
> I cannot understand about usage of "enabled".  Is this simply English
> representation issue?

It was a 'typo'.

> > > -     fprintf(stderr, "usage: pccardc <subcommand> <arg> ...\n");
> > > -     fprintf(stderr, "subcommands:\n");
> > > +     fprintf(stderr, "Usage:\n");
> > > +     fprintf(stderr, "\t%s <subcommand> <arg> ...\n", argv[0]);
> > > +     fprintf(stderr, "Subcommands:\n");
> > >       for (i = 0; subcommands[i].name; i++)
> > > -             fprintf(stderr, "\t%s\n\t\t%s\n",
> > > +             fprintf(stderr, "\t%s\t: %s\n",
> > >                   subcommands[i].name, subcommands[i].help);
> > 
> > However, I'm not sure why we are changing the output.  It seems
> > gratiutious.
> 
> I cannot find "gratiutious" in my dictionary... But changing output is
> not necessary, I'll keep it as original.

You just defined gratiutious.  'Is not necessary.  Provides no
additional functionality.  Is different just to be different.'

> > Again, we use warn one place, and then err.  Any chance of keeping it
> > consistent in all places.
> 
> I think we should use "warn" when program can continue to work and use
> "err" when cannot continue to work and exit, is it right?
> 
> Of course, err() should not use to display usage, as Philippe said. :-)

Philippe is the expert in the usafe of err/warn.


Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message