From owner-svn-src-head@FreeBSD.ORG Tue Nov 11 18:47:29 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0909410E; Tue, 11 Nov 2014 18:47:29 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7FB9CAEB; Tue, 11 Nov 2014 18:47:27 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id sABIlI32091697 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 11 Nov 2014 21:47:18 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id sABIlIw3091696; Tue, 11 Nov 2014 21:47:18 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 11 Nov 2014 21:47:18 +0300 From: Gleb Smirnoff To: Hans Petter Selasky Subject: Re: svn commit: r274376 - in head/sys: net netinet Message-ID: <20141111184717.GF1031@FreeBSD.org> References: <201411111206.sABC60Z5044716@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201411111206.sABC60Z5044716@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2014 18:47:29 -0000 On Tue, Nov 11, 2014 at 12:06:00PM +0000, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Tue Nov 11 12:05:59 2014 H> New Revision: 274376 H> URL: https://svnweb.freebsd.org/changeset/base/274376 H> H> Log: H> Fix some minor TSO issues: H> - Improve description of TSO limits. H> - Remove a not needed KASSERT() H> - Remove some not needed variable casts. H> H> Sponsored by: Mellanox Technologies H> Discussed with: lstewart @ H> MFC after: 1 week Thanks a lot for comments in if_var.h and removed KASSERT in if.c. I'm working on new ifnet API in my private branch and today spent half an hour trying to understand conventions around these three fields. -- Totus tuus, Glebius.