From owner-freebsd-chromium@FreeBSD.ORG  Wed Dec 26 14:39:46 2012
Return-Path: <owner-freebsd-chromium@FreeBSD.ORG>
Delivered-To: freebsd-chromium@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C2EBDAA7
 for <freebsd-chromium@freebsd.org>; Wed, 26 Dec 2012 14:39:46 +0000 (UTC)
 (envelope-from jbeich@tormail.org)
Received: from outgoing.tormail.org (outgoing.tormail.org [82.221.96.22])
 by mx1.freebsd.org (Postfix) with ESMTP id 74FF78FC12
 for <freebsd-chromium@freebsd.org>; Wed, 26 Dec 2012 14:39:46 +0000 (UTC)
Received: from localhost ([127.0.0.1] helo=internal.tormail.org)
 by outgoing.tormail.org with esmtp (Exim 4.72)
 (envelope-from <jbeich@tormail.org>) id 1Tns8w-000233-Jr
 for freebsd-chromium@freebsd.org; Wed, 26 Dec 2012 17:39:39 +0300
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tormail.org;
 s=tm; 
 h=Message-Id:X-TorMail-User:Content-Type:MIME-Version:Date:Subject:To:From;
 bh=OaWv6V2dI2ibiWPHveVCWw17S0fpfM3c/4iEkDWI9f8=; 
 b=iWzMH9DlxxVbQn3dym/Jgr6268VcqYGvLz17PzgRkXuJQic9DJf/1JPh7QdbFxGiJn2eNQBPUAoSCI3suAAN3+Qe9wBle8hj9WfIcx3nDH3LDq6HQ7AKFc1jqRIZDLesuPoX5oKNy/m2c0qBgu2agoaRA18+ZuzPMj9ujN0gD7E=;
Received: from jbeich by internal.tormail.org with local (Exim 4.63)
 (envelope-from <jbeich@tormail.org>) id 1Tns6P-000IsX-DH
 for freebsd-chromium@freebsd.org; Wed, 26 Dec 2012 14:37:04 +0000
From: Jan Beich <jbeich@tormail.org>
To: freebsd-chromium@freebsd.org
Subject: openat, O_DIRECTORY, shell_integration_linux.cc
Date: Wed, 26 Dec 2012 12:38:06 -0200
MIME-Version: 1.0
Content-Type: text/plain
X-TorMail-User: jbeich
Message-Id: <1Tns6P-000IsX-DH@internal.tormail.org>
X-BeenThere: freebsd-chromium@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: FreeBSD-specific Chromium issues <freebsd-chromium.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-chromium>, 
 <mailto:freebsd-chromium-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-chromium>
List-Post: <mailto:freebsd-chromium@freebsd.org>
List-Help: <mailto:freebsd-chromium-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-chromium>, 
 <mailto:freebsd-chromium-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Dec 2012 14:39:46 -0000

Are there issues when using openat() et al. on FreeBSD 8.0 and forward?

Index: www/chromium/files/patch-chrome__browser__shell_integration_linux.cc
===================================================================
--- www/chromium/files/patch-chrome__browser__shell_integration_linux.cc	(revision 309498)
+++ www/chromium/files/patch-chrome__browser__shell_integration_linux.cc	(working copy)
@@ -4,7 +4,7 @@
    if (!PathService::Get(chrome::DIR_USER_DESKTOP, &desktop_path))
      return false;
  
-+#if !defined(OS_FREEBSD)
++#ifdef O_DIRECTORY
 +// BSD: Linux-specific calls like openat are used so defined out for BSD.
    int desktop_fd = open(desktop_path.value().c_str(), O_RDONLY | O_DIRECTORY);
    if (desktop_fd < 0)